9639fe704c
Fixes: #34342 Visiting the following page will call gSSP indefinitely in a loop and logs errors from `on-demand-entries-client`: ```js const Home = () => null export default Home export function getServerSideProps() { console.log("gssp called") return { notFound: true } } ``` We should not keep fetching the page if it returns 404 as it can introduce unnecessary data requests. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
34 lines
926 B
TypeScript
34 lines
926 B
TypeScript
import { createNext } from 'e2e-utils'
|
|
import { NextInstance } from 'test/lib/next-modes/base'
|
|
import { waitFor } from 'next-test-utils'
|
|
import webdriver from 'next-webdriver'
|
|
|
|
describe('getServerSideProps returns notFound: true', () => {
|
|
let next: NextInstance
|
|
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: {
|
|
'pages/index.js': `
|
|
const Home = () => null
|
|
export default Home
|
|
|
|
export function getServerSideProps() {
|
|
console.log("gssp called")
|
|
return { notFound: true }
|
|
}
|
|
`,
|
|
},
|
|
dependencies: {},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it('should not poll indefinitely', async () => {
|
|
const browser = await webdriver(next.appPort, '/')
|
|
await waitFor(3000)
|
|
await browser.close()
|
|
const logOccurrences = next.cliOutput.split('gssp called').length - 1
|
|
expect(logOccurrences).toBe(1)
|
|
})
|
|
})
|