rsnext/packages/next
Tobias Koppers 3f11815b02
avoid merging global css in a way that leaks into other chunk groups (#67373)
### What?

This disallows merging of global css with styles that appear on other
pages/chunk groups.

### Why?

Before we made the assumption that all CSS is written in a way that it
only affects the elements it should really affect.

In general writing CSS in that way is recommended. In App Router styles
are only added and never removed. This means when a user uses
client-side navigations to navigate the application, styles from all
previous pages are still active on the current page. To avoid visual
artefacts one need to write CSS in a way that it only affects certain
elements. Usually this can be archived by using class names. CSS Modules
even enforce this recommendation.

Assuming that all styles are written this way allows to optimize CSS
loading as request count can be reduced when (small) styles are merged
together.

But turns out that some applications are written differently. They use
global styles that are not scoped to a class name (e. g. to `body`
directly instead) and use them in different sections of the application.
They are structured in a way that doesn't allow client-side navigations
between these sections. This should be valid too, which makes our
assumption not always holding true.

This PR changes the algorithm so we only make that assumption for CSS
Modules, but not for global CSS. While this affects the ability to
optimize, applications usually do not use too much global CSS files, so
that can be accepted.

fixes #64773
2024-07-05 03:33:02 -07:00
..
compat
experimental/testmode
font
image-types
legacy
navigation-types/compat chore: update prettier to 3.2.5 (#65092) 2024-05-08 21:47:14 +02:00
src avoid merging global css in a way that leaks into other chunk groups (#67373) 2024-07-05 03:33:02 -07:00
types fix css order for some edge cases in App Dir (#66500) 2024-06-04 10:18:52 +02:00
amp.d.ts
amp.js
app.d.ts
app.js
babel.d.ts
babel.js
cache.d.ts
cache.js
client.d.ts
client.js
config.d.ts
config.js
constants.d.ts
constants.js
document.d.ts
document.js
dynamic.d.ts
dynamic.js
error.d.ts
error.js
head.d.ts
head.js
headers.d.ts
headers.js
image.d.ts
image.js
index.d.ts Upgrade TypeScript to v5.5.2 (#67113) 2024-07-04 10:03:46 +02:00
jest.d.ts
jest.js
license.md
link.d.ts
link.js
navigation.d.ts
navigation.js
og.d.ts
og.js
package.json Bump minimum Node.js version to 18.18 (up from 18.17) (#67274) 2024-07-05 09:21:57 +00:00
README.md chore(docs): improve visual appearance of badges in README.md (#67254) 2024-06-28 07:29:25 +00:00
router.d.ts
router.js
script.d.ts
script.js
server.d.ts experimental: unstable_after (#65038) 2024-05-20 08:49:53 +00:00
server.js experimental: unstable_after (#65038) 2024-05-20 08:49:53 +00:00
taskfile-ncc.js Disable ncc cache instead of cache cleaning (#64804) 2024-04-20 15:45:35 +02:00
taskfile-swc.js feat(turbopack-ecmascript): use import attributes for annotations (#59370) 2024-05-16 02:58:43 +00:00
taskfile-watch.js
taskfile-webpack.js Fix source map loading failure for path-to-regexp (#66242) 2024-05-27 16:16:08 +00:00
taskfile.js Upgrade TypeScript to v5.5.2 (#67113) 2024-07-04 10:03:46 +02:00
tsconfig.json Upgrade TypeScript to v5.5.2 (#67113) 2024-07-04 10:03:46 +02:00
types.d.ts Upgrade TypeScript to v5.5.2 (#67113) 2024-07-04 10:03:46 +02:00
types.js Upgrade typescript to 5.3 (#64043) 2024-04-17 18:35:29 +02:00
web-vitals.d.ts
web-vitals.js
webpack.config.js refactor: deprecate future directory (#66432) 2024-06-04 15:23:23 +00:00

Next.js

Getting Started

Used by some of the world's largest companies, Next.js enables you to create full-stack web applications by extending the latest React features, and integrating powerful Rust-based JavaScript tooling for the fastest builds.

Documentation

Visit https://nextjs.org/docs to view the full documentation.

Community

The Next.js community can be found on GitHub Discussions where you can ask questions, voice ideas, and share your projects with other people.

To chat with other community members you can join the Next.js Discord server.

Do note that our Code of Conduct applies to all Next.js community channels. Users are highly encouraged to read and adhere to them to avoid repercussions.

Contributing

Contributions to Next.js are welcome and highly appreciated. However, before you jump right into it, we would like you to review our Contribution Guidelines to make sure you have a smooth experience contributing to Next.js.

Good First Issues:

We have a list of good first issues that contain bugs that have a relatively limited scope. This is a great place for newcomers and beginners alike to get started, gain experience, and get familiar with our contribution process.

Authors

A list of the original co-authors of Next.js that helped bring this amazing framework to life!


Security

If you believe you have found a security vulnerability in Next.js, we encourage you to responsibly disclose this and NOT open a public issue. We will investigate all legitimate reports. Email security@vercel.com to disclose any security vulnerabilities. Alternatively, you can visit this link to know more about Vercel's security and report any security vulnerabilities.