rsnext/packages/eslint-plugin-next/lib/rules/inline-script-id.js
Sukka 3ee458e376
fix(#34030): ignore non-checkable jsx spread attribute (#34473)
## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes #34030.

The PR is still WIP as the test case hasn't been added, help or change is welcome.

cc @no-ya @ijjk 

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
2022-02-25 04:15:25 +00:00

70 lines
2.2 KiB
JavaScript

module.exports = {
meta: {
docs: {
description:
'next/script components with inline content must specify an `id` attribute.',
recommended: true,
url: 'https://nextjs.org/docs/messages/inline-script-id',
},
},
create: function (context) {
let nextScriptImportName = null
return {
ImportDeclaration(node) {
if (node.source.value === 'next/script') {
nextScriptImportName = node.specifiers[0].local.name
}
},
JSXElement(node) {
if (nextScriptImportName == null) return
if (
node.openingElement &&
node.openingElement.name &&
node.openingElement.name.name !== nextScriptImportName
) {
return
}
const attributeNames = new Set()
let hasNonCheckableSpreadAttribute = false
node.openingElement.attributes.forEach((attribute) => {
// Early return if we already have a non-checkable spread attribute, for better performance
if (hasNonCheckableSpreadAttribute) return
if (attribute.type === 'JSXAttribute') {
attributeNames.add(attribute.name.name)
} else if (attribute.type === 'JSXSpreadAttribute') {
if (attribute.argument && attribute.argument.properties) {
attribute.argument.properties.forEach((property) => {
attributeNames.add(property.key.name)
})
} else {
// JSXSpreadAttribute without properties is not checkable
hasNonCheckableSpreadAttribute = true
}
}
})
// https://github.com/vercel/next.js/issues/34030
// If there is a non-checkable spread attribute, we simply ignore them
if (hasNonCheckableSpreadAttribute) return
if (
node.children.length > 0 ||
attributeNames.has('dangerouslySetInnerHTML')
) {
if (!attributeNames.has('id')) {
context.report({
node,
message:
'next/script components with inline content must specify an `id` attribute. See: https://nextjs.org/docs/messages/inline-script-id',
})
}
}
},
}
},
}