b0f87fbc7c
Bundle the ssr client layer for RSC, this solves the problem when there's an esm package is using on client components, but esm imports the installed react instead of the built-in react version since esm imports is not intercepted by require hook. After bundling the ssr client layer and treating react as externals, now react compiles as cjs externals and could be intercepted by require hook, other code are bundled together which can also get optimized. ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see `contributing.md` Co-authored-by: Shu Ding <g@shud.in> Co-authored-by: JJ Kasper <jj@jjsweb.site>
124 lines
3.6 KiB
TypeScript
124 lines
3.6 KiB
TypeScript
/* eslint-env jest */
|
|
|
|
import { NextInstance } from 'test/lib/next-modes/base'
|
|
import { fetchViaHTTP } from 'next-test-utils'
|
|
import { createNext, FileRef } from 'e2e-utils'
|
|
import cheerio from 'cheerio'
|
|
import path from 'path'
|
|
|
|
describe('app-dir with middleware', () => {
|
|
if ((global as any).isNextDeploy) {
|
|
it('should skip next deploy for now', () => {})
|
|
return
|
|
}
|
|
|
|
let next: NextInstance
|
|
|
|
afterAll(() => next.destroy())
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: new FileRef(path.join(__dirname, 'app-middleware')),
|
|
dependencies: {
|
|
react: 'experimental',
|
|
'react-dom': 'experimental',
|
|
},
|
|
})
|
|
})
|
|
|
|
describe.each([
|
|
{
|
|
title: 'Serverless Functions',
|
|
path: '/api/dump-headers-serverless',
|
|
toJson: (res: Response) => res.json(),
|
|
},
|
|
{
|
|
title: 'Edge Functions',
|
|
path: '/api/dump-headers-edge',
|
|
toJson: (res: Response) => res.json(),
|
|
},
|
|
{
|
|
title: 'next/headers',
|
|
path: '/headers',
|
|
toJson: async (res: Response) => {
|
|
const $ = cheerio.load(await res.text())
|
|
return JSON.parse($('#headers').text())
|
|
},
|
|
},
|
|
])('Mutate request headers for $title', ({ path, toJson }) => {
|
|
it(`Adds new headers`, async () => {
|
|
const res = await fetchViaHTTP(next.url, path, null, {
|
|
headers: {
|
|
'x-from-client': 'hello-from-client',
|
|
},
|
|
})
|
|
expect(await toJson(res)).toMatchObject({
|
|
'x-from-client': 'hello-from-client',
|
|
'x-from-middleware': 'hello-from-middleware',
|
|
})
|
|
})
|
|
|
|
it(`Deletes headers`, async () => {
|
|
const res = await fetchViaHTTP(
|
|
next.url,
|
|
path,
|
|
{
|
|
'remove-headers': 'x-from-client1,x-from-client2',
|
|
},
|
|
{
|
|
headers: {
|
|
'x-from-client1': 'hello-from-client',
|
|
'X-From-Client2': 'hello-from-client',
|
|
},
|
|
}
|
|
)
|
|
|
|
const json = await toJson(res)
|
|
expect(json).not.toHaveProperty('x-from-client1')
|
|
expect(json).not.toHaveProperty('X-From-Client2')
|
|
expect(json).toMatchObject({
|
|
'x-from-middleware': 'hello-from-middleware',
|
|
})
|
|
|
|
// Should not be included in response headers.
|
|
expect(res.headers.get('x-middleware-override-headers')).toBeNull()
|
|
expect(
|
|
res.headers.get('x-middleware-request-x-from-middleware')
|
|
).toBeNull()
|
|
expect(res.headers.get('x-middleware-request-x-from-client1')).toBeNull()
|
|
expect(res.headers.get('x-middleware-request-x-from-client2')).toBeNull()
|
|
})
|
|
|
|
it(`Updates headers`, async () => {
|
|
const res = await fetchViaHTTP(
|
|
next.url,
|
|
path,
|
|
{
|
|
'update-headers':
|
|
'x-from-client1=new-value1,x-from-client2=new-value2',
|
|
},
|
|
{
|
|
headers: {
|
|
'x-from-client1': 'old-value1',
|
|
'X-From-Client2': 'old-value2',
|
|
'x-from-client3': 'old-value3',
|
|
},
|
|
}
|
|
)
|
|
expect(await toJson(res)).toMatchObject({
|
|
'x-from-client1': 'new-value1',
|
|
'x-from-client2': 'new-value2',
|
|
'x-from-client3': 'old-value3',
|
|
'x-from-middleware': 'hello-from-middleware',
|
|
})
|
|
|
|
// Should not be included in response headers.
|
|
expect(res.headers.get('x-middleware-override-headers')).toBeNull()
|
|
expect(
|
|
res.headers.get('x-middleware-request-x-from-middleware')
|
|
).toBeNull()
|
|
expect(res.headers.get('x-middleware-request-x-from-client1')).toBeNull()
|
|
expect(res.headers.get('x-middleware-request-x-from-client2')).toBeNull()
|
|
expect(res.headers.get('x-middleware-request-x-from-client3')).toBeNull()
|
|
})
|
|
})
|
|
})
|