73b473991c
Follow-up on https://github.com/vercel/next.js/pull/38534#pullrequestreview-1035020450 This lets us use modern JS/TS syntax in ESLint rules and avoid issues like #38530 and #36693 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
67 lines
1.6 KiB
TypeScript
67 lines
1.6 KiB
TypeScript
import rule from '@next/eslint-plugin-next/dist/rules/google-font-preconnect'
|
|
import { RuleTester } from 'eslint'
|
|
;(RuleTester as any).setDefaultConfig({
|
|
parserOptions: {
|
|
ecmaVersion: 2020,
|
|
sourceType: 'module',
|
|
ecmaFeatures: {
|
|
modules: true,
|
|
jsx: true,
|
|
},
|
|
},
|
|
})
|
|
const ruleTester = new RuleTester()
|
|
|
|
ruleTester.run('google-font-preconnect', rule, {
|
|
valid: [
|
|
`export const Test = () => (
|
|
<div>
|
|
<link rel="preconnect" href="https://fonts.gstatic.com"/>
|
|
<link
|
|
href={process.env.NEXT_PUBLIC_CANONICAL_URL}
|
|
rel="canonical"
|
|
/>
|
|
<link
|
|
href={new URL("../public/favicon.ico", import.meta.url).toString()}
|
|
rel="icon"
|
|
/>
|
|
</div>
|
|
)
|
|
`,
|
|
],
|
|
|
|
invalid: [
|
|
{
|
|
code: `
|
|
export const Test = () => (
|
|
<div>
|
|
<link href="https://fonts.gstatic.com"/>
|
|
</div>
|
|
)
|
|
`,
|
|
errors: [
|
|
{
|
|
message:
|
|
'`rel="preconnect"` is missing from Google Font. See: https://nextjs.org/docs/messages/google-font-preconnect',
|
|
type: 'JSXOpeningElement',
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `
|
|
export const Test = () => (
|
|
<div>
|
|
<link rel="preload" href="https://fonts.gstatic.com"/>
|
|
</div>
|
|
)
|
|
`,
|
|
errors: [
|
|
{
|
|
message:
|
|
'`rel="preconnect"` is missing from Google Font. See: https://nextjs.org/docs/messages/google-font-preconnect',
|
|
type: 'JSXOpeningElement',
|
|
},
|
|
],
|
|
},
|
|
],
|
|
})
|