No description
Find a file
Thiago Morales 645f70128f
Pass missing incrementalCacheHandlerPath to IncrementalCache instance (#38433)
# Description
Hi guys! First all, thanks for provide a way to use some custom external cache resource for ISR feature. _(done here: https://github.com/vercel/next.js/pull/37258 and https://github.com/vercel/next.js/pull/37326)_

I managed to get it working by creating my custom external cache resource _(using redis)_ that implements the new `CacheHandler`. _(overriding my own `get` and `set` methods and using the FileSystemCache as fallback as well)_  

I'm planning to release some kind of plugin to encapsulate and parse the client's `next.config.js` and bring an initial support for redis using this new Next.js feature.

So, I really don't know if this was intentional, but I noticed that the new `incrementalCacheHandlerPath` prop wasn't passed to the `IncrementalCache` instance in `base-server`.

This PR just connects the wires for this feature, and also provide the default value (`undefined`) to the relative experimental prop config. _(to avoid the warnings as shown below)_

<img width="858" alt="Screen Shot 2022-07-07 at 19 37 46" src="https://user-images.githubusercontent.com/4661217/177882897-831ade73-26ba-493a-b0cf-3de62cfd708f.png">
2022-07-11 16:53:17 +00:00
.github Update CI job skipping based on related changes (#38479) 2022-07-11 09:42:51 -05:00
.husky Replace pre-commit with husky (#38350) 2022-07-06 11:14:16 -05:00
.vscode Ensure server components entries are not part of the pages buildmanifest (#38416) 2022-07-07 22:17:17 +02:00
bench Update of @babel/core (#37145) 2022-05-31 01:00:12 +00:00
docs Update api-middlewares.md (#38499) 2022-07-11 11:18:56 +00:00
errors feat: build edge functions with node.js modules and fail at runtime (#38234) 2022-07-06 20:54:44 +00:00
examples Fix url of tRPC's next-minimal-starter (#38452) 2022-07-11 12:30:16 +00:00
packages Pass missing incrementalCacheHandlerPath to IncrementalCache instance (#38433) 2022-07-11 16:53:17 +00:00
scripts Update CI job skipping based on related changes (#38479) 2022-07-11 09:42:51 -05:00
test Enable css import in rsc server side (#38418) 2022-07-11 17:23:21 +02:00
.alexignore Enable Alex documentation linting for docs (#26598) 2021-06-25 11:40:50 -05:00
.alexrc Add instructions to create pages directory and add an index.js file to it (#35971) 2022-04-15 14:40:37 +02:00
.eslintignore Add typedef for next-bundle-analyzer (#35075) 2022-05-22 16:32:20 -05:00
.eslintrc.json test: warn on substr() usage (#35499) 2022-03-24 18:35:33 -04:00
.gitattributes the way towards webpack 5 typings (#29105) 2021-09-21 19:17:16 +02:00
.gitignore Update .gitignore to include @next/swc-wasm-nodejs (#38025) 2022-06-25 22:53:54 -05:00
.npmrc declare pnpm7 as engine (#37303) 2022-05-30 13:13:36 +00:00
.prettierignore Update to leverage pnpm for monorepo (#37259) 2022-05-28 23:35:16 -05:00
.prettierignore_staged Update to leverage pnpm for monorepo (#37259) 2022-05-28 23:35:16 -05:00
.prettierrc.json Prettier trailingComma default value to es5 since 2.0 (#14391) 2020-06-22 13:25:24 +02:00
azure-pipelines.yml Add docs condition for all azure steps (#38519) 2022-07-11 11:15:25 -05:00
CODE_OF_CONDUCT.md updated code of conduct to v2.1 (#34208) 2022-02-10 18:11:42 -06:00
contributing.md chore: detect no canary verification (#37788) 2022-06-22 14:54:11 +00:00
jest.config.js Don't swallow test failures caused by POSIX signals (#32688) 2021-12-21 12:52:07 -06:00
lerna.json v12.2.3-canary.0 2022-07-11 14:35:12 +02:00
license.md Update license year 2022-01-13 16:02:34 +01:00
lint-staged.config.js Replace pre-commit with husky (#38350) 2022-07-06 11:14:16 -05:00
package.json Implement new client-side router (#37551) 2022-07-06 21:16:47 +00:00
plopfile.js Clarify test types during scaffolding (#34638) 2022-02-21 12:09:32 -06:00
pnpm-lock.yaml v12.2.3-canary.0 2022-07-11 14:35:12 +02:00
pnpm-workspace.yaml Update to leverage pnpm for monorepo (#37259) 2022-05-28 23:35:16 -05:00
readme.md Monorepo (#5341) 2018-10-01 01:02:10 +02:00
release.js Fix labels for release sections 2021-11-21 13:11:54 +01:00
run-tests.js Expose test timings token for e2e tests (#37756) 2022-06-16 11:56:43 -05:00
SECURITY.md Add link to security email directly. (#33358) 2022-01-15 21:33:43 -06:00
test-file.txt Add additional file serving tests (#12479) 2020-05-04 11:58:19 -05:00
tsconfig-tsec.json Integrate tsec into the linting process (#33746) 2022-02-24 16:59:18 -08:00
tsconfig.json Adds tests to ensure eslint-plugin-next's available rules are properly exported and recommended rules are correctly defined. (#38183) 2022-06-30 11:31:33 -05:00
tsec-exemptions.json Fix various Trusted Types violations without use of policy (#34726) 2022-05-05 00:11:36 +00:00
turbo.json Update to leverage turbo for build/prepublish (#37280) 2022-05-30 19:05:27 -05:00
UPGRADING.md Move upgrading guide to /docs (#10727) 2020-02-28 23:46:18 +01:00
vercel.json Silence GH Comments for Preview URLs (#18766) 2020-11-03 21:59:47 +00:00

Next.js

Getting Started

Visit https://nextjs.org/learn to get started with Next.js.

Documentation

Visit https://nextjs.org/docs to view the full documentation.

Who is using Next.js?

Next.js is used by the world's leading companies. Check out the Next.js Showcase to learn more.

Community

The Next.js community can be found on GitHub Discussions, where you can ask questions, voice ideas, and share your projects.

To chat with other community members you can join the Next.js Discord.

Our Code of Conduct applies to all Next.js community channels.

Contributing

Please see our contributing.md.

Good First Issues

We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.

Authors

Security

If you believe you have found a security vulnerability in Next.js, we encourage you to responsibly disclose this and not open a public issue. We will investigate all legitimate reports. Email security@vercel.com to disclose any security vulnerabilities.

https://vercel.com/security