73b473991c
Follow-up on https://github.com/vercel/next.js/pull/38534#pullrequestreview-1035020450 This lets us use modern JS/TS syntax in ESLint rules and avoid issues like #38530 and #36693 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
69 lines
1.4 KiB
TypeScript
69 lines
1.4 KiB
TypeScript
import rule from '@next/eslint-plugin-next/dist/rules/no-title-in-document-head'
|
|
import { RuleTester } from 'eslint'
|
|
;(RuleTester as any).setDefaultConfig({
|
|
parserOptions: {
|
|
ecmaVersion: 2018,
|
|
sourceType: 'module',
|
|
ecmaFeatures: {
|
|
modules: true,
|
|
jsx: true,
|
|
},
|
|
},
|
|
})
|
|
const ruleTester = new RuleTester()
|
|
|
|
ruleTester.run('no-title-in-document-head', rule, {
|
|
valid: [
|
|
`import Head from "next/head";
|
|
|
|
class Test {
|
|
render() {
|
|
return (
|
|
<Head>
|
|
<title>My page title</title>
|
|
</Head>
|
|
);
|
|
}
|
|
}`,
|
|
|
|
`import Document, { Html, Head } from "next/document";
|
|
|
|
class MyDocument extends Document {
|
|
render() {
|
|
return (
|
|
<Html>
|
|
<Head>
|
|
</Head>
|
|
</Html>
|
|
);
|
|
}
|
|
}
|
|
|
|
export default MyDocument;
|
|
`,
|
|
],
|
|
|
|
invalid: [
|
|
{
|
|
code: `
|
|
import { Head } from "next/document";
|
|
|
|
class Test {
|
|
render() {
|
|
return (
|
|
<Head>
|
|
<title>My page title</title>
|
|
</Head>
|
|
);
|
|
}
|
|
}`,
|
|
errors: [
|
|
{
|
|
message:
|
|
'Do not use `<title>` element with `<Head />` component from `next/document`. Titles should defined at the page-level using `<Head />` from `next/head` instead. See: https://nextjs.org/docs/messages/no-title-in-document-head',
|
|
type: 'JSXElement',
|
|
},
|
|
],
|
|
},
|
|
],
|
|
})
|