No description
Find a file
Hiroshi Ogawa 764e29c170
fix(31013): add base path to preflight request url (#31101)
Fixes https://github.com/vercel/next.js/issues/31013

My understanding is that there are currently two functions `Router.change` and `Router.prefetch` leading to `Router._preflightRequest` and they pass `options.as` URL differently regarding base path.
In this PR, such difference will be handled in `Router._preflightRequest` to add base path before actually fetching.
Thanks for the review!

P.S.
Since middleware feature is a relatively new, official maintainers might not want external contributions around this area at this stage.
I totally understand such situation, so please let me know if that's the case. I can look for other issues to investigate instead.


## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
2021-11-09 19:03:05 +00:00
.github Bump cancel-workflow-action to 0.9.1 (#31210) 2021-11-09 10:05:19 -06:00
.vscode Additional bench tracing improvements (#29325) 2021-09-27 12:57:37 +02:00
bench improve windows support for benchmark (#31032) 2021-11-08 11:39:39 +01:00
docs Update upgrading.md (#31173) 2021-11-08 20:53:25 +00:00
errors Add next-swc jest transform (#30993) 2021-11-08 17:35:04 +01:00
examples docs(examples): Update with-iron-session to latest iron-session API (#30956) 2021-11-09 09:30:15 -06:00
packages fix(31013): add base path to preflight request url (#31101) 2021-11-09 19:03:05 +00:00
scripts Fix version in trace (#30982) 2021-11-04 20:56:30 +00:00
test fix(31013): add base path to preflight request url (#31101) 2021-11-09 19:03:05 +00:00
.alexignore Enable Alex documentation linting for docs (#26598) 2021-06-25 11:40:50 -05:00
.alexrc Enable Alex documentation linting for docs (#26598) 2021-06-25 11:40:50 -05:00
.eslintignore Exclude SWC test input/output JS from eslint checks 2021-10-10 13:17:04 +02:00
.eslintrc.json [ESLint] Remove error when file patterns are unmatched + ESLint setup changes (#27119) 2021-07-16 20:19:08 +02:00
.gitattributes the way towards webpack 5 typings (#29105) 2021-09-21 19:17:16 +02:00
.gitignore make sure "webpack" exists in the repo for typings (#30371) 2021-10-29 17:57:55 +00:00
.npmrc Remove version prefix 2018-10-02 01:35:56 +02:00
.prettierignore Exclude bench/nested-deps from prettier check 2021-10-10 13:20:16 +02:00
.prettierignore_staged Add/styled jsx swc (#29005) 2021-09-15 09:24:31 +02:00
.prettierrc.json Prettier trailingComma default value to es5 since 2.0 (#14391) 2020-06-22 13:25:24 +02:00
azure-pipelines.yml Bump "engines" to node >= 12.22.0 (#29949) 2021-10-15 20:55:14 +00:00
CODE_OF_CONDUCT.md Update Code of Conduct email address (#12108) 2020-04-22 16:27:24 +02:00
contributing.md Chore/rust workflow (#30577) 2021-10-29 13:56:56 -05:00
jest.config.js Add next-swc jest transform (#30993) 2021-11-08 17:35:04 +01:00
lerna.json v12.0.4-canary.3 2021-11-09 17:18:40 +01:00
license.md Update license year for all packages 2021-01-11 11:12:19 +01:00
lint-staged.config.js Replace CLIEngine with ESLint (#25801) 2021-06-09 13:54:10 +02:00
package.json next-swc: Add displayNameAndId of styled-components (#31189) 2021-11-09 10:05:31 +00:00
readme.md Monorepo (#5341) 2018-10-01 01:02:10 +02:00
release.js Match last PR mention in commit message for release notes 2021-05-07 19:53:38 +02:00
run-tests.js Update resolving for node_modules trace pass (#30985) 2021-11-04 20:09:37 -05:00
SECURITY.md Create SECURITY.md 2020-07-13 19:25:08 +02:00
skip-docs-change.js Update repo scripts to separate folder (#26787) 2021-07-01 13:41:27 +02:00
test-file.txt Add additional file serving tests (#12479) 2020-05-04 11:58:19 -05:00
tsconfig.json Update test set-up to leverage playwright when able to (#28634) 2021-09-13 14:36:25 +02:00
UPGRADING.md Move upgrading guide to /docs (#10727) 2020-02-28 23:46:18 +01:00
vercel.json Silence GH Comments for Preview URLs (#18766) 2020-11-03 21:59:47 +00:00
yarn.lock next-swc: Add displayNameAndId of styled-components (#31189) 2021-11-09 10:05:31 +00:00

Next.js

Getting Started

Visit https://nextjs.org/learn to get started with Next.js.

Documentation

Visit https://nextjs.org/docs to view the full documentation.

Who is using Next.js?

Next.js is used by the world's leading companies. Check out the Next.js Showcase to learn more.

Community

The Next.js community can be found on GitHub Discussions, where you can ask questions, voice ideas, and share your projects.

To chat with other community members you can join the Next.js Discord.

Our Code of Conduct applies to all Next.js community channels.

Contributing

Please see our contributing.md.

Good First Issues

We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.

Authors