7bdb61c28d
## What? Was investigating an issue with Turbopack and MDX, in the process found a few bugs: - When you have a `tsconfig.json` or `jsconfig.json` the `baseUrl: '.'` is used by default which causes the top-level directories to be available as e.g. `design-system` (without a prefix). - This is not how TypeScript's default setting for `baseUrl` works. While it should resolve `paths` relative to `.` when none is specified it does not do additional resolving for the top level directories/files. - When `"baseUrl": "."` is added to `tsconfig.js` explicitly it handles the top level directories. - `modularizeImports` and other SWC transforms weren't applied to `.mdx` files when `experimental.mdxRs` is enabled, which caused compilation to fail. - `modularIzeImports` and other SWC transforms are not applied to `.mdx` files when using Turbopack. - @kwonoj is investigating this, will be handled in a follow-up PR. ## How? - Added a test suite for `modularizeImports` with MDX tests - Removed the condition that disables swcLoader in webpack when using mdxRs - Changed the check for `tsconfig.json` / `jsconfig.json` baseUrl to include if it was implicitly or explicitly set, disabled the module resolving when it is implicitly set <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> |
||
|---|---|---|
| .. | ||
| cart.js | ||
| search.js | ||