21e677e95b
## What? After landing #49855 I found a few more edge cases with not-found not behaving as expected: - When navigating directly to a not-found page (e.g. `/testabc`) the error boundary would not reset as there were multiple levels being triggered at the same time. - When running in production navigating back/forward to the not found page caused the page to become empty Both issues are fixed by this PR. I've added tests for both. ## How? - Ensures `asNotFound` is not set on the layout-router, it causes all levels to trigger not-found, even though only app-router needs it - Ensures navigations to 404 are always a mpaNavigation (browser navigation) instead of trying to do a client-side navigation (mirrors what we do in `pages`) Fixes NEXT-1209 Fixes NEXT-1218 Fixes #49823 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> |
||
|---|---|---|
| .. | ||
| pages | ||
| test | ||
| big.json | ||