archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rsnext/packages/next/server
History
Balázs Orbán 9639fe704c
Ensure we don't poll page in development when notFound: true is returned (#34352) 
Fixes: #34342

Visiting the following page will call gSSP indefinitely in a loop and logs errors from `on-demand-entries-client`:
```js
const Home = () => null
export default Home
        
export function getServerSideProps() {
  console.log("gssp called")
  return { notFound: true }
}
```

We should not keep fetching the page if it returns 404 as  it can introduce unnecessary data requests.

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`



Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
2022-02-16 18:53:48 +00:00
..
api-utils Adding step to build the app with docker in existing projects (#34083) 2022-02-11 15:27:10 -06:00
base-http Optimize the web server size (#34242) 2022-02-11 19:56:25 +00:00
dev Add support for "type": "module" in package.json (#33637) 2022-02-15 16:24:11 +00:00
lib Refactor base server to remove native dependencies (#33499) 2022-01-20 21:25:44 +00:00
web Deprecate concurrentFeatures with runtime (#34068) 2022-02-08 14:16:46 +01:00
accept-header.ts Implement Middleware RFC (#30081) 2021-10-20 17:52:11 +00:00
base-server.ts Ensure we don't poll page in development when notFound: true is returned (#34352) 2022-02-16 18:53:48 +00:00
config-shared.ts Remove experimental image optimization feature (#34349) 2022-02-15 01:36:51 +00:00
config-utils.ts Remove webpack 4 support (#29660) 2021-10-06 17:40:01 +02:00
config.ts Align reactRoot config between server and webpack config (#34328) 2022-02-14 16:18:57 +00:00
crypto-utils.ts Move next-server directory files to server directory (#26756) 2021-06-30 13:44:40 +02:00
denormalize-page-path.ts Fix dynamic routes with pages under index folder (#32440) 2021-12-13 20:36:31 +00:00
font-utils.ts Move next-server directory files to server directory (#26756) 2021-06-30 13:44:40 +02:00
get-page-files.ts Move next-server directory files to server directory (#26756) 2021-06-30 13:44:40 +02:00
get-route-from-entrypoint.ts Move next-server directory files to server directory (#26756) 2021-06-30 13:44:40 +02:00
htmlescape.ts Upgrade to Prettier 2 (#13061) 2020-05-18 15:24:37 -04:00
image-config.ts Add JSDoc to config options (#32915) 2022-02-05 19:49:52 -06:00
image-optimizer.ts Use updated recursive rm fs method for image-optimizer (#34210) 2022-02-11 02:28:55 +00:00
incremental-cache.ts Update to leverage response-cache for image-optimizer (#34075) 2022-02-08 18:46:59 -05:00
load-components.ts Align reactRoot config between server and webpack config (#34328) 2022-02-14 16:18:57 +00:00
next-server.ts Remove experimental image optimization feature (#34349) 2022-02-15 01:36:51 +00:00
next.ts Base Http for BaseServer (#32999) 2022-01-14 21:01:35 +00:00
node-polyfill-fetch.js Pre-compile more dependencies (#32742) 2022-01-17 15:17:22 +00:00
node-polyfill-web-streams.js Deprecate concurrentFeatures with runtime (#34068) 2022-02-08 14:16:46 +01:00
normalize-page-path.ts Fix dynamic routes with pages under index folder (#32440) 2021-12-13 20:36:31 +00:00
optimize-amp.ts Move next-server directory files to server directory (#26756) 2021-06-30 13:44:40 +02:00
render-result.ts Use ReadableStream in RenderResult (#34005) 2022-02-05 01:13:02 +00:00
render.tsx Ensure we don't poll page in development when notFound: true is returned (#34352) 2022-02-16 18:53:48 +00:00
request-meta.ts Ensure we don't poll page in development when notFound: true is returned (#34352) 2022-02-16 18:53:48 +00:00
require.ts middlewares: limit process.env to inferred usage (#33186) 2022-01-12 13:09:24 +00:00
response-cache.ts Add Error Handing section for ISR (#34360) 2022-02-15 14:22:15 -06:00
router.ts Optimize the web server size (#34242) 2022-02-11 19:56:25 +00:00
send-payload.ts Refactor base server to remove native dependencies (#33499) 2022-01-20 21:25:44 +00:00
serve-static.ts Add support for AVIF to next/image (#29683) 2021-10-11 23:17:47 +00:00
server-route-utils.ts Fix encoding error with location and refresh headers (#33763) 2022-01-28 16:20:34 +00:00
utils.ts Refactor base server to remove native dependencies (#33499) 2022-01-20 21:25:44 +00:00
web-server.ts Optimize the web server size (#34242) 2022-02-11 19:56:25 +00:00