archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rsnext/test
History
JJ Kasper 16caf41995
Fix inconsistency with 404 getStaticProps cache-control (#66674) 
While investigating unexpected stale responses when leveraging
`getStaticProps` on the 404 page noticed we have an inconsistency
between local and deployed due to `Cache-Control` being set to
`no-store, must-revalidate` even though a revalidate period is provided.
The inconsistency also differs between the HTML response and the data
response `_next/data` which causes even more unexpected behavior. To
avoid this behavior, this replaces the handling to ensure we honor the
originally provided revalidate period during `notFound: true` for the
`Cache-Control` header.

Validated against provided reproduction here
https://github.com/fusdev0/next-notfound-revalidate
Deployment:
https://vercel.live/link/next-notfound-revalidate-govzskknf-vtest314-ijjk-testing.vercel.app/fallback-blocking/fasdf

Prior PR for prior context that introduced this
https://github.com/vercel/next.js/pull/19165

x-ref: [slack
thread](https://vercel.slack.com/archives/C0676QZBWKS/p1717492459342109)
2024-06-10 12:13:05 -07:00
..
.stats-app Update React from f994737d14 to 1df34bdf62 (19.0.0-rc.0) (#66533) 2024-06-10 12:06:38 +00:00
development feat(turbopack-ecmascript): cache external modules with wrapper (#63337) 2024-06-10 15:39:40 +00:00
e2e [ppr] Enable static shell debugging in other environments (#65483) 2024-06-10 09:42:32 -07:00
examples Replace createNextDescribe with nextTestSetup (#64817) 2024-04-25 12:06:12 -06:00
integration Fix inconsistency with 404 getStaticProps cache-control (#66674) 2024-06-10 12:13:05 -07:00
lib Update React from f994737d14 to 1df34bdf62 (19.0.0-rc.0) (#66533) 2024-06-10 12:06:38 +00:00
production Add timeout/retry handling for fetch cache (#66652) 2024-06-10 11:34:36 -07:00
unit fix: only generate prefetch rsc for ppr enabled routes (#66395) 2024-06-03 12:55:05 -07:00
.gitignore ci(workflow): enable test trace upload (#51107) 2023-06-12 17:14:13 +00:00
build-turbopack-build-tests-manifest.js Ensure production integration test results are uploaded (#63706) 2024-03-26 10:41:16 +01:00
build-turbopack-dev-tests-manifest.js Rename turbopack-tests-manifest to turbopack-dev-tests-manifest (#63409) 2024-03-19 10:26:14 +01:00
build-turbopack-tests-manifest.d.ts Update Turbopack test manifest from GitHub Actions artifact (#58394) 2023-11-24 16:48:12 +01:00
get-test-filter.js run tests from test suite that are not listed in the manifest (#58401) 2024-01-11 07:38:35 +00:00
jest-setup-after-env.ts Decrease default test timeouts (#56116) 2023-09-27 23:55:20 +00:00
ppr-tests-manifest.json Add timeout/retry handling for fetch cache (#66652) 2024-06-10 11:34:36 -07:00
readme.md
related-tests-manifest.json Reapply "chore(test): run related E2E deploy tests on PRs" (#64682) (#64712) 2024-04-19 11:02:43 +02:00
test-file.txt
turbopack-build-tests-manifest.json Add timeout/retry handling for fetch cache (#66652) 2024-06-10 11:34:36 -07:00
turbopack-dev-examples-manifest.json Fix last examples for Turbopack (#64020) 2024-04-03 16:02:52 +02:00
turbopack-dev-tests-manifest.json feat(turbopack-ecmascript): cache external modules with wrapper (#63337) 2024-06-10 15:39:40 +00:00

readme.md

See Testing for more information on how you can run/write/debug tests for Next.js.