rsnext/packages/next
Zack Tanner a4f46bc157
Fix empty white page with parallel routes + loading boundaries (#61597)
### What
When navigating to a page that uses a loading boundary + parallel route,
an empty white screen would be displayed rather than the loading state /
final state

### Why
With parallel routes, the RSC data is an array of data paths, each
corresponding with one of the parallel segments rendered on the page.

During the navigation event, when we iterate over this data, we call
`applyFlightData` with this data path & an empty cache node.
`applyFlightData` checks to see if the flight data contains cache nodes
("seed data"). If it doesn't, then that means it has no work to do, and
it bails out. Pre-PPR and in the case of having a `loading.js` file,
`walkTreeWithFlightRouterState` doesn't return any seed data, just
router state. This means that `applyFlightData` will not have any work
to do on the new cache node, and leaves it untouched.

Once `applyFlightData` is finished, but while still in the flight data
path loop, we reassign `currentCache` to the empty cache object we
created prior to `applyFlightData`. But since that cache node has
remained empty, the next iteration of the loop is going to be inspecting
a now empty cache, rather than the actual "current" cache. Now there's
no existing cache to copy into the new cache. The app now doesn't know
about any cache nodes.

### How
It doesn't seem like we should be re-assigning `currentCache` to the new
cache. In the context of a navigation, it seems more accurate to always
assume `currentCache` is the cache _now_, since it won't actually be
applied to the state until the action has finished (`mutable.cache` is
currently taking care of this).

Closes NEXT-2223
Fixes #61080
2024-02-12 16:30:52 -08:00
..
compat
experimental/testmode
font
image-types
legacy
navigation-types/compat
src Fix empty white page with parallel routes + loading boundaries (#61597) 2024-02-12 16:30:52 -08:00
types Revert "feat(next/image)!: remove squoosh in favor of sharp as optional dep" (#61810) 2024-02-08 11:00:34 +00:00
amp.d.ts
amp.js
app.d.ts
app.js
babel.d.ts
babel.js
cache.d.ts Dynamic APIs (#60645) 2024-01-23 16:06:12 -08:00
cache.js Dynamic APIs (#60645) 2024-01-23 16:06:12 -08:00
client.d.ts
client.js
config.d.ts
config.js
constants.d.ts
constants.js
document.d.ts
document.js
dynamic.d.ts
dynamic.js
error.d.ts
error.js
head.d.ts
head.js
headers.d.ts
headers.js
image.d.ts
image.js
index.d.ts fix(ts): auto-complete next/headers (#60817) 2024-01-18 15:01:22 +01:00
jest.d.ts
jest.js
license.md chore: update Copyright time from 2023 to 2024 (#60071) 2024-01-02 11:06:02 -08:00
link.d.ts
link.js
navigation.d.ts
navigation.js
og.d.ts Move ImageResponse to next/og (#56662) 2023-10-19 14:26:48 +00:00
og.js Move ImageResponse to next/og (#56662) 2023-10-19 14:26:48 +00:00
package.json v14.1.1-canary.51 2024-02-12 23:21:34 +00:00
README.md Fix duplicate line in README (#61691) 2024-02-06 20:45:14 +00:00
router.d.ts
router.js
script.d.ts
script.js
server.d.ts feat(ts): expose MiddlewareConfig interface (#61576) 2024-02-05 11:15:58 -08:00
server.js Fix next/server api alias for ESM pkg (#61721) 2024-02-06 16:59:24 +00:00
taskfile-ncc.js Use precompiled source-map in overlay middleware (#60932) 2024-01-22 10:04:34 +01:00
taskfile-swc.js Use new JSX transform (#56294) 2023-12-09 00:17:50 +01:00
taskfile-watch.js
taskfile-webpack.js avoid output of webpack stats (#61023) 2024-01-23 11:53:19 +01:00
taskfile.js Revert "feat(next/image)!: remove squoosh in favor of sharp as optional dep" (#61810) 2024-02-08 11:00:34 +00:00
tsconfig.json Use new JSX transform (#56294) 2023-12-09 00:17:50 +01:00
web-vitals.d.ts
web-vitals.js
webpack.config.js Update React from 60a927d04 to 2bc7d336a (#61522) 2024-02-05 18:22:27 -08:00

Next.js

Getting Started

Used by some of the world's largest companies, Next.js enables you to create full-stack web applications by extending the latest React features, and integrating powerful Rust-based JavaScript tooling for the fastest builds.

Documentation

Visit https://nextjs.org/docs to view the full documentation.

Community

The Next.js community can be found on GitHub Discussions where you can ask questions, voice ideas, and share your projects with other people.

To chat with other community members you can join the Next.js Discord server.

Do note that our Code of Conduct applies to all Next.js community channels. Users are highly encouraged to read and adhere to them to avoid repercussions.

Contributing

Contributions to Next.js are welcome and highly appreciated. However, before you jump right into it, we would like you to review our Contribution Guidelines to make sure you have a smooth experience contributing to Next.js.

Good First Issues:

We have a list of good first issues that contain bugs that have a relatively limited scope. This is a great place for newcomers and beginners alike to get started, gain experience, and get familiar with our contribution process.

Authors

A list of the original co-authors of Next.js that helped bring this amazing framework to life!


Security

If you believe you have found a security vulnerability in Next.js, we encourage you to responsibly disclose this and NOT open a public issue. We will investigate all legitimate reports. Email security@vercel.com to disclose any security vulnerabilities. Alternatively, you can visit this link to know more about Vercel's security and report any security vulnerabilities.