a721a749d8
## What? I was investigating reports of server actions with `revalidatePath` / `revalidateTag` not invalidating the client-side router cache. Managed to reproduce the issue here: https://github.com/timneutkens/server-actions-test (requires Vercel KV to run). While looking at the reducer I noticed a few things that seemed off: - setTimeout to trigger another `dispatch` on the same reducer with the fetched data. This means that it would not be part of the same React Transition. - redirects weren't applying the data that comes back from the server (that allows for single hop navigation) - prefetchCache was invalidated, but the router cache which is used for back/forward navigation was not invalidated, causing back/forward to not get the new data. - all changes in the action-reducer mutate. The part that shouldn't mutate was part of that setTimeout dispatch. This PR aims to solve all of these by reworking the actions reducer to be handled similarly to `router.refresh()`. Since `router.refresh()` was already modeled to be similar to `revalidatePath('/')`. The flow is now more like the other reducers: - Fetch data - Wait for the data to come back - Apply the data to the cache and keep it in a mutable variable - Return the new cache and otherwise values like the url In particular the actions reducer handles a few extra specifics: - Resolving the server action promise, so that the value is passed to the application code waiting for the result. - Applying redirects from `redirect()` calls. - Invalidating the router cache ## Followup changes - Currently when calling `revalidatePath('/dashboard')` the entire router cache is invalidated instead of only `/dashboard` and further down, this is not in scope for this PR but still has to be added. - `notFound()`, I'm not sure how this is supposed to work exactly, it doesn't really make sense to me to allow it in server actions. Kudos @feedthejim for helping investigate for this PR 😌 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> |
||
|---|---|---|
| .. | ||
| create-next-app | ||
| eslint-config-next | ||
| eslint-plugin-next | ||
| font | ||
| next | ||
| next-bundle-analyzer | ||
| next-codemod | ||
| next-env | ||
| next-mdx | ||
| next-plugin-storybook | ||
| next-polyfill-module | ||
| next-polyfill-nomodule | ||
| next-swc | ||
| react-dev-overlay | ||
| react-refresh-utils | ||
| third-parties | ||