ad98cda23b
### What When triggering an interception route that has a parent with dynamic params, and then later going to "refresh" the tree, either by calling `router.refresh` or revalidating in a server action, the refresh action would silently fail and the router would be in a bad state. ### Why Because of the dependency that interception routes currently have on `FlightRouterState` for dynamic params extraction, we need to make sure the refetch has the full tree so that it can properly extract earlier params. Since the refreshing logic traversed parallel routes and scoped the refresh to that particular segment, it would skip over earlier segments, and so when the server attempted to diff the tree, it would return an updated tree that corresponded with the wrong segment (`[locale]` rather than `["locale", "en", "d]`). Separately, since a page segment might be `__PAGE__?{"locale": "en"}` rather than just `__PAGE__`, this updates the refetch marker logic to do a partial match on the page segment key. ### How This keeps a reference to the root of the updated tree so that the refresh always starts at the top. This has the side effect of re-rendering more data when making the "stale" refetch request, but this is necessary until we can decouple `FlightRouterState` from interception routes. shout-out to @steve-marmalade for helping find this bug and providing excellent Replays to help track it down 🙏 x-ref: - https://github.com/vercel/next.js/discussions/63900 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-2986 |
||
---|---|---|
.. | ||
404-page-router | ||
app-dir | ||
app-dir-legacy-edge-runtime-config | ||
basepath | ||
browserslist | ||
browserslist-extends | ||
cancel-request | ||
children-page | ||
config-promise-export | ||
config-schema-check | ||
conflicting-app-page-error | ||
custom-app-render | ||
disable-js-preload | ||
dynamic-route-interpolation | ||
edge-api-endpoints-can-receive-body | ||
edge-async-local-storage | ||
edge-can-read-request-body | ||
edge-can-use-wasm-files | ||
edge-compiler-can-import-blob-assets | ||
edge-compiler-module-exports-preference | ||
edge-configurable-runtime | ||
edge-pages-support | ||
edge-runtime-pages-api-route | ||
edge-runtime-uses-edge-light-import-specifier-for-packages | ||
esm-externals | ||
favicon-short-circuit | ||
fetch-failures-have-good-stack-traces-in-edge-runtime | ||
getserversideprops | ||
handle-non-hoisted-swc-helpers | ||
hello-world | ||
i18n-api-support | ||
i18n-data-fetching-redirect | ||
i18n-data-route | ||
i18n-default-locale-redirect | ||
i18n-disallow-multiple-locales | ||
i18n-ignore-redirect-source-locale | ||
i18n-ignore-rewrite-source-locale | ||
i18n-preferred-locale-detection | ||
ignore-invalid-popstateevent | ||
instrumentation-hook | ||
instrumentation-hook-src | ||
link-with-api-rewrite | ||
manual-client-base-path | ||
middleware-base-path | ||
middleware-custom-matchers | ||
middleware-custom-matchers-basepath | ||
middleware-custom-matchers-i18n | ||
middleware-dynamic-basepath-matcher | ||
middleware-fetches-with-any-http-method | ||
middleware-fetches-with-body | ||
middleware-general | ||
middleware-matcher | ||
middleware-redirects | ||
middleware-request-header-overrides | ||
middleware-responses | ||
middleware-rewrites | ||
middleware-shallow-link | ||
middleware-trailing-slash | ||
module-layer | ||
multi-zone | ||
new-link-behavior | ||
next-font | ||
next-head | ||
next-image-forward-ref | ||
next-phase | ||
next-script | ||
no-eslint-warn-with-no-eslint-config | ||
nonce-head-manager | ||
og-api | ||
opentelemetry | ||
optimized-loading | ||
pages-performance-mark | ||
postcss-config-cjs | ||
prerender | ||
prerender-native-module | ||
proxy-request-with-middleware | ||
react-dnd-compile | ||
reload-scroll-backforward-restoration | ||
repeated-forward-slashes-error | ||
skip-trailing-slash-redirect | ||
socket-io | ||
ssr-react-context | ||
streaming-ssr | ||
styled-jsx | ||
swc-warnings | ||
switchable-runtime | ||
test-template/{{ toFileName name }} | ||
test-utils-tests/basic | ||
testmode | ||
third-parties | ||
trailingslash-with-rewrite | ||
transpile-packages | ||
type-module-interop | ||
typescript-version-no-warning | ||
typescript-version-warning | ||
undici-fetch | ||
useselectedlayoutsegment-s-in-pages-router | ||
yarn-pnp/test | ||
basepath-trailing-slash.test.ts | ||
basepath.test.ts | ||
example-file.txt | ||
example.txt | ||
prerender-crawler.test.ts | ||
prerender-native-module.test.ts | ||
prerender.test.ts |