rsnext/packages
Tim Neutkens b55a023b49
Refactor flight-manifest-plugin to use compilation.entrypoints directly (#62636)
## What?

Currently flight-manifest-plugin relies on looping over all webpack
chunk groups and trying to infer the entrypoint name from them, which
can be brittle in cases where the chunk group doesn't match exactly with
the entrypoint, which happens for the `_not-found` entrypoint for
example.

This PR changes the implementation to use `compilation.entrypoints`
directly. `compilation.entrypoints` is a `Map` where the key is the
entrypoint name and the value is the entrypoint chunk group, exactly
what this logic was looking for in the current implementation.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-2637
2024-02-28 12:48:25 +01:00
..
create-next-app v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
eslint-config-next v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
eslint-plugin-next v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
font v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
next Refactor flight-manifest-plugin to use compilation.entrypoints directly (#62636) 2024-02-28 12:48:25 +01:00
next-bundle-analyzer v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
next-codemod v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
next-env v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
next-mdx v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
next-plugin-storybook v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
next-polyfill-module v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
next-polyfill-nomodule v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
next-swc fix(next-swc): Provide tokio context required for WASM plugins (#62441) 2024-02-28 11:28:00 +09:00
react-refresh-utils v14.1.1-canary.77 2024-02-27 23:20:54 +00:00
third-parties v14.1.1-canary.77 2024-02-27 23:20:54 +00:00