a720dbdc4c
Fixes: #38232 Fixes: https://github.com/vercel/next.js/issues/36893 Version [12.1.1-canary.5](https://github.com/vercel/next.js/releases/tag/v12.1.1-canary.5) introduced a bug, more specifically this PR: https://github.com/vercel/next.js/pull/34836 The issue described in #38232 is that the following code starts both the dev and prod servers: ```js const start = require('next/dist/cli/next-start') start.nextStart() ``` I searched a bit and found that `lib/get-project-dir.ts#getProjectDir()` now imports `bin/next.ts`6b8e499c7b/packages/next/lib/get-project-dir.ts (L3)and it calls a CLI command via6b8e499c7b/packages/next/bin/next.ts (L137)This `command` should not be defined, but it fallbacks to `defaultCommand`, which is `dev` (that explains why the dev server is also started) This PR moves the `cliCommand` types and `commands` variable to a new separate file instead of `bin/next.ts`, to avoid running a CLI command when we import any file that also imports `lib/get-project-dir.ts` Not sure how integration tests can be added for this issue, but feel free to tell me. Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
97 lines
2.7 KiB
JavaScript
Executable file
97 lines
2.7 KiB
JavaScript
Executable file
#!/usr/bin/env node
|
|
|
|
import arg from 'next/dist/compiled/arg/index.js'
|
|
import { startServer } from '../server/lib/start-server'
|
|
import { printAndExit } from '../server/lib/utils'
|
|
import * as Log from '../build/output/log'
|
|
import isError from '../lib/is-error'
|
|
import { getProjectDir } from '../lib/get-project-dir'
|
|
import { cliCommand } from '../lib/commands'
|
|
|
|
const nextStart: cliCommand = (argv) => {
|
|
const validArgs: arg.Spec = {
|
|
// Types
|
|
'--help': Boolean,
|
|
'--port': Number,
|
|
'--hostname': String,
|
|
'--keepAliveTimeout': Number,
|
|
|
|
// Aliases
|
|
'-h': '--help',
|
|
'-p': '--port',
|
|
'-H': '--hostname',
|
|
}
|
|
let args: arg.Result<arg.Spec>
|
|
try {
|
|
args = arg(validArgs, { argv })
|
|
} catch (error) {
|
|
if (isError(error) && error.code === 'ARG_UNKNOWN_OPTION') {
|
|
return printAndExit(error.message, 1)
|
|
}
|
|
throw error
|
|
}
|
|
if (args['--help']) {
|
|
console.log(`
|
|
Description
|
|
Starts the application in production mode.
|
|
The application should be compiled with \`next build\` first.
|
|
|
|
Usage
|
|
$ next start <dir> -p <port>
|
|
|
|
<dir> represents the directory of the Next.js application.
|
|
If no directory is provided, the current directory will be used.
|
|
|
|
Options
|
|
--port, -p A port number on which to start the application
|
|
--hostname, -H Hostname on which to start the application (default: 0.0.0.0)
|
|
--keepAliveTimeout Max milliseconds to wait before closing inactive connections
|
|
--help, -h Displays this message
|
|
`)
|
|
process.exit(0)
|
|
}
|
|
|
|
const dir = getProjectDir(args._[0])
|
|
let port: number =
|
|
args['--port'] || (process.env.PORT && parseInt(process.env.PORT)) || 3000
|
|
const host = args['--hostname'] || '0.0.0.0'
|
|
|
|
if (process.env.__NEXT_FORCED_PORT) {
|
|
port = parseInt(process.env.__NEXT_FORCED_PORT, 10) || 0
|
|
}
|
|
|
|
const keepAliveTimeoutArg: number | undefined = args['--keepAliveTimeout']
|
|
if (
|
|
typeof keepAliveTimeoutArg !== 'undefined' &&
|
|
(Number.isNaN(keepAliveTimeoutArg) ||
|
|
!Number.isFinite(keepAliveTimeoutArg) ||
|
|
keepAliveTimeoutArg < 0)
|
|
) {
|
|
printAndExit(
|
|
`Invalid --keepAliveTimeout, expected a non negative number but received "${keepAliveTimeoutArg}"`,
|
|
1
|
|
)
|
|
}
|
|
|
|
const keepAliveTimeout = keepAliveTimeoutArg
|
|
? Math.ceil(keepAliveTimeoutArg)
|
|
: undefined
|
|
|
|
startServer({
|
|
dir,
|
|
hostname: host,
|
|
port,
|
|
keepAliveTimeout,
|
|
})
|
|
.then(async (app) => {
|
|
const appUrl = `http://${app.hostname}:${app.port}`
|
|
Log.ready(`started server on ${host}:${app.port}, url: ${appUrl}`)
|
|
await app.prepare()
|
|
})
|
|
.catch((err) => {
|
|
console.error(err)
|
|
process.exit(1)
|
|
})
|
|
}
|
|
|
|
export { nextStart }
|