b522b94cce
## Feature As the title, support `has` match, `local` that works the same with the `rewrites` and `redirects` of next.config.js on middleware config. With this PR, you can write the config like the following: ```js export const config = { matcher: [ "/foo", { source: "/bar" }, { source: "/baz", has: [ { type: 'header', key: 'x-my-header', value: 'my-value', } ] }, { source: "/en/asdf", locale: false, }, ] } ``` Also, fixes https://github.com/vercel/next.js/issues/39428 related https://github.com/vercel/edge-functions/issues/178, https://github.com/vercel/edge-functions/issues/179 - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` Co-authored-by: JJ Kasper <jj@jjsweb.site>
530 lines
17 KiB
TypeScript
530 lines
17 KiB
TypeScript
/* eslint-disable jest/no-identical-title */
|
|
import { createNext, FileRef } from 'e2e-utils'
|
|
import { NextInstance } from 'test/lib/next-modes/base'
|
|
import { check, fetchViaHTTP } from 'next-test-utils'
|
|
import { join } from 'path'
|
|
import webdriver from 'next-webdriver'
|
|
|
|
describe('Middleware can set the matcher in its config', () => {
|
|
let next: NextInstance
|
|
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: new FileRef(join(__dirname, 'app')),
|
|
dependencies: {},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it('does add the header for root request', async () => {
|
|
const response = await fetchViaHTTP(next.url, '/')
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
expect(await response.text()).toContain('root page')
|
|
})
|
|
|
|
it('adds the header for a matched path', async () => {
|
|
const response = await fetchViaHTTP(next.url, '/with-middleware')
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
expect(await response.text()).toContain('This should run the middleware')
|
|
})
|
|
|
|
it('adds the header for a matched data path (with header)', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/with-middleware.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(await response.json()).toMatchObject({
|
|
pageProps: {
|
|
message: 'Hello, cruel world.',
|
|
},
|
|
})
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('adds the header for a matched data path (without header)', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/with-middleware.json`
|
|
)
|
|
expect(await response.json()).toMatchObject({
|
|
pageProps: {
|
|
message: 'Hello, cruel world.',
|
|
},
|
|
})
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('adds the header for another matched path', async () => {
|
|
const response = await fetchViaHTTP(next.url, '/another-middleware')
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
expect(await response.text()).toContain(
|
|
'This should also run the middleware'
|
|
)
|
|
})
|
|
|
|
it('adds the header for another matched data path', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/another-middleware.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(await response.json()).toMatchObject({
|
|
pageProps: {
|
|
message: 'Hello, magnificent world.',
|
|
},
|
|
})
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('does add the header for root data request', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/index.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(await response.json()).toMatchObject({
|
|
pageProps: {
|
|
message: 'Hello, world.',
|
|
},
|
|
})
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('should load matches in client matchers correctly', async () => {
|
|
const browser = await webdriver(next.url, '/')
|
|
|
|
await check(async () => {
|
|
const matchers = await browser.eval(
|
|
(global as any).isNextDev
|
|
? 'window.__DEV_MIDDLEWARE_MATCHERS'
|
|
: 'window.__MIDDLEWARE_MATCHERS'
|
|
)
|
|
|
|
return matchers &&
|
|
matchers.some((m) => m.regexp.includes('with-middleware')) &&
|
|
matchers.some((m) => m.regexp.includes('another-middleware'))
|
|
? 'success'
|
|
: 'failed'
|
|
}, 'success')
|
|
})
|
|
|
|
it('should navigate correctly with matchers', async () => {
|
|
const browser = await webdriver(next.url, '/')
|
|
await browser.eval('window.beforeNav = 1')
|
|
|
|
await browser.elementByCss('#to-another-middleware').click()
|
|
await browser.waitForElementByCss('#another-middleware')
|
|
|
|
expect(JSON.parse(await browser.elementByCss('#props').text())).toEqual({
|
|
message: 'Hello, magnificent world.',
|
|
})
|
|
|
|
await browser.elementByCss('#to-index').click()
|
|
await browser.waitForElementByCss('#index')
|
|
|
|
await browser.elementByCss('#to-blog-slug-1').click()
|
|
await browser.waitForElementByCss('#blog')
|
|
expect(JSON.parse(await browser.elementByCss('#props').text())).toEqual({
|
|
message: 'Hello, magnificent world.',
|
|
params: {
|
|
slug: 'slug-1',
|
|
},
|
|
})
|
|
|
|
await browser.elementByCss('#to-blog-slug-2').click()
|
|
await check(
|
|
() => browser.eval('document.documentElement.innerHTML'),
|
|
/"slug":"slug-2"/
|
|
)
|
|
expect(JSON.parse(await browser.elementByCss('#props').text())).toEqual({
|
|
message: 'Hello, magnificent world.',
|
|
params: {
|
|
slug: 'slug-2',
|
|
},
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('using a single matcher', () => {
|
|
let next: NextInstance
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: {
|
|
'pages/[...route].js': `
|
|
export default function Page({ message }) {
|
|
return <div>
|
|
<p>root page</p>
|
|
<p>{message}</p>
|
|
</div>
|
|
}
|
|
|
|
export const getServerSideProps = ({ params }) => {
|
|
return {
|
|
props: {
|
|
message: "Hello from /" + params.route.join("/")
|
|
}
|
|
}
|
|
}
|
|
`,
|
|
'middleware.js': `
|
|
import { NextResponse } from 'next/server'
|
|
export const config = {
|
|
matcher: '/middleware/works'
|
|
};
|
|
export default (req) => {
|
|
const res = NextResponse.next();
|
|
res.headers.set('X-From-Middleware', 'true');
|
|
return res;
|
|
}
|
|
`,
|
|
},
|
|
dependencies: {},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it('does not add the header for root request', async () => {
|
|
const response = await fetchViaHTTP(next.url, '/')
|
|
expect(response.headers.get('X-From-Middleware')).toBeFalsy()
|
|
})
|
|
|
|
it('does not add the header for root data request', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/index.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(response.headers.get('X-From-Middleware')).toBeFalsy()
|
|
})
|
|
|
|
it('adds the header for a matched path', async () => {
|
|
const response = await fetchViaHTTP(next.url, '/middleware/works')
|
|
expect(await response.text()).toContain('Hello from /middleware/works')
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('adds the headers for a matched data path (with header)', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/middleware/works.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(await response.json()).toMatchObject({
|
|
pageProps: {
|
|
message: 'Hello from /middleware/works',
|
|
},
|
|
})
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('adds the header for a matched data path (without header)', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/middleware/works.json`
|
|
)
|
|
expect(await response.json()).toMatchObject({
|
|
pageProps: {
|
|
message: 'Hello from /middleware/works',
|
|
},
|
|
})
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('does not add the header for an unmatched path', async () => {
|
|
const response = await fetchViaHTTP(next.url, '/about/me')
|
|
expect(await response.text()).toContain('Hello from /about/me')
|
|
expect(response.headers.get('X-From-Middleware')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('using root matcher', () => {
|
|
let next: NextInstance
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: {
|
|
'pages/index.js': `
|
|
export function getStaticProps() {
|
|
return {
|
|
props: {
|
|
message: 'hello world'
|
|
}
|
|
}
|
|
}
|
|
|
|
export default function Home({ message }) {
|
|
return <div>Hi there!</div>
|
|
}
|
|
`,
|
|
'middleware.js': `
|
|
import { NextResponse } from 'next/server'
|
|
export default (req) => {
|
|
const res = NextResponse.next();
|
|
res.headers.set('X-From-Middleware', 'true');
|
|
return res;
|
|
}
|
|
|
|
export const config = { matcher: '/' };
|
|
`,
|
|
},
|
|
dependencies: {},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it('adds the header to the /', async () => {
|
|
const response = await fetchViaHTTP(next.url, '/')
|
|
expect(response.status).toBe(200)
|
|
expect(Object.fromEntries(response.headers)).toMatchObject({
|
|
'x-from-middleware': 'true',
|
|
})
|
|
})
|
|
|
|
it('adds the header to the /index', async () => {
|
|
const response = await fetchViaHTTP(next.url, '/index')
|
|
expect(Object.fromEntries(response.headers)).toMatchObject({
|
|
'x-from-middleware': 'true',
|
|
})
|
|
})
|
|
|
|
it('adds the header for a matched data path (with header)', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/index.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(await response.json()).toMatchObject({
|
|
pageProps: {
|
|
message: 'hello world',
|
|
},
|
|
})
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('adds the header for a matched data path (without header)', async () => {
|
|
const response = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/index.json`
|
|
)
|
|
expect(await response.json()).toMatchObject({
|
|
pageProps: {
|
|
message: 'hello world',
|
|
},
|
|
})
|
|
expect(response.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
})
|
|
|
|
describe.each([
|
|
{ title: '' },
|
|
{ title: ' and trailingSlash', trailingSlash: true },
|
|
])('using a single matcher with i18n$title', ({ trailingSlash }) => {
|
|
let next: NextInstance
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: {
|
|
'pages/index.js': `
|
|
export default function Page({ message }) {
|
|
return <div>
|
|
<p>{message}</p>
|
|
</div>
|
|
}
|
|
export const getServerSideProps = ({ params, locale }) => ({
|
|
props: { message: \`(\${locale}) Hello from /\` }
|
|
})
|
|
`,
|
|
'pages/[...route].js': `
|
|
export default function Page({ message }) {
|
|
return <div>
|
|
<p>catchall page</p>
|
|
<p>{message}</p>
|
|
</div>
|
|
}
|
|
export const getServerSideProps = ({ params, locale }) => ({
|
|
props: { message: \`(\${locale}) Hello from /\` + params.route.join("/") }
|
|
})
|
|
`,
|
|
'middleware.js': `
|
|
import { NextResponse } from 'next/server'
|
|
export const config = { matcher: '/' };
|
|
export default (req) => {
|
|
const res = NextResponse.next();
|
|
res.headers.set('X-From-Middleware', 'true');
|
|
return res;
|
|
}
|
|
`,
|
|
'next.config.js': `
|
|
module.exports = {
|
|
${trailingSlash ? 'trailingSlash: true,' : ''}
|
|
i18n: {
|
|
localeDetection: false,
|
|
locales: ['es', 'en'],
|
|
defaultLocale: 'en',
|
|
}
|
|
}
|
|
`,
|
|
},
|
|
dependencies: {},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it(`adds the header for a matched path`, async () => {
|
|
const res1 = await fetchViaHTTP(next.url, `/`)
|
|
expect(await res1.text()).toContain(`(en) Hello from /`)
|
|
expect(res1.headers.get('X-From-Middleware')).toBe('true')
|
|
const res2 = await fetchViaHTTP(next.url, `/es`)
|
|
expect(await res2.text()).toContain(`(es) Hello from /`)
|
|
expect(res2.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('adds the header for a mathed root path with /index', async () => {
|
|
const res1 = await fetchViaHTTP(next.url, `/index`)
|
|
expect(await res1.text()).toContain(`(en) Hello from /`)
|
|
expect(res1.headers.get('X-From-Middleware')).toBe('true')
|
|
const res2 = await fetchViaHTTP(next.url, `/es/index`)
|
|
expect(await res2.text()).toContain(`(es) Hello from /`)
|
|
expect(res2.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it(`adds the headers for a matched data path`, async () => {
|
|
const res1 = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/en.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(await res1.json()).toMatchObject({
|
|
pageProps: { message: `(en) Hello from /` },
|
|
})
|
|
expect(res1.headers.get('X-From-Middleware')).toBe('true')
|
|
const res2 = await fetchViaHTTP(
|
|
next.url,
|
|
`/_next/data/${next.buildId}/es.json`,
|
|
undefined
|
|
)
|
|
expect(await res2.json()).toMatchObject({
|
|
pageProps: { message: `(es) Hello from /` },
|
|
})
|
|
expect(res2.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it(`does not add the header for an unmatched path`, async () => {
|
|
const response = await fetchViaHTTP(next.url, `/about/me`)
|
|
expect(await response.text()).toContain('Hello from /about/me')
|
|
expect(response.headers.get('X-From-Middleware')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe.each([
|
|
{ title: '' },
|
|
{ title: ' and trailingSlash', trailingSlash: true },
|
|
])(
|
|
'using a single matcher with i18n and basePath$title',
|
|
({ trailingSlash }) => {
|
|
let next: NextInstance
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: {
|
|
'pages/index.js': `
|
|
export default function Page({ message }) {
|
|
return <div>
|
|
<p>root page</p>
|
|
<p>{message}</p>
|
|
</div>
|
|
}
|
|
export const getServerSideProps = ({ params, locale }) => ({
|
|
props: { message: \`(\${locale}) Hello from /\` }
|
|
})
|
|
`,
|
|
'pages/[...route].js': `
|
|
export default function Page({ message }) {
|
|
return <div>
|
|
<p>catchall page</p>
|
|
<p>{message}</p>
|
|
</div>
|
|
}
|
|
export const getServerSideProps = ({ params, locale }) => ({
|
|
props: { message: \`(\${locale}) Hello from /\` + params.route.join("/") }
|
|
})
|
|
`,
|
|
'middleware.js': `
|
|
import { NextResponse } from 'next/server'
|
|
export const config = { matcher: '/' };
|
|
export default (req) => {
|
|
const res = NextResponse.next();
|
|
res.headers.set('X-From-Middleware', 'true');
|
|
return res;
|
|
}
|
|
`,
|
|
'next.config.js': `
|
|
module.exports = {
|
|
${trailingSlash ? 'trailingSlash: true,' : ''}
|
|
basePath: '/root',
|
|
i18n: {
|
|
localeDetection: false,
|
|
locales: ['es', 'en'],
|
|
defaultLocale: 'en',
|
|
}
|
|
}
|
|
`,
|
|
},
|
|
dependencies: {},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it(`adds the header for a matched path`, async () => {
|
|
const res1 = await fetchViaHTTP(next.url, `/root`)
|
|
expect(await res1.text()).toContain(`(en) Hello from /`)
|
|
expect(res1.headers.get('X-From-Middleware')).toBe('true')
|
|
const res2 = await fetchViaHTTP(next.url, `/root/es`)
|
|
expect(await res2.text()).toContain(`(es) Hello from /`)
|
|
expect(res2.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it('adds the header for a mathed root path with /index', async () => {
|
|
const res1 = await fetchViaHTTP(next.url, `/root/index`)
|
|
expect(await res1.text()).toContain(`(en) Hello from /`)
|
|
expect(res1.headers.get('X-From-Middleware')).toBe('true')
|
|
const res2 = await fetchViaHTTP(next.url, `/root/es/index`)
|
|
expect(await res2.text()).toContain(`(es) Hello from /`)
|
|
expect(res2.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it(`adds the headers for a matched data path`, async () => {
|
|
const res1 = await fetchViaHTTP(
|
|
next.url,
|
|
`/root/_next/data/${next.buildId}/en.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(await res1.json()).toMatchObject({
|
|
pageProps: { message: `(en) Hello from /` },
|
|
})
|
|
expect(res1.headers.get('X-From-Middleware')).toBe('true')
|
|
const res2 = await fetchViaHTTP(
|
|
next.url,
|
|
`/root/_next/data/${next.buildId}/es.json`,
|
|
undefined,
|
|
{ headers: { 'x-nextjs-data': '1' } }
|
|
)
|
|
expect(await res2.json()).toMatchObject({
|
|
pageProps: { message: `(es) Hello from /` },
|
|
})
|
|
expect(res2.headers.get('X-From-Middleware')).toBe('true')
|
|
})
|
|
|
|
it(`does not add the header for an unmatched path`, async () => {
|
|
const response = await fetchViaHTTP(next.url, `/root/about/me`)
|
|
expect(await response.text()).toContain('Hello from /about/me')
|
|
expect(response.headers.get('X-From-Middleware')).toBeNull()
|
|
})
|
|
}
|
|
)
|