73b473991c
Follow-up on https://github.com/vercel/next.js/pull/38534#pullrequestreview-1035020450 This lets us use modern JS/TS syntax in ESLint rules and avoid issues like #38530 and #36693 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
187 lines
4.1 KiB
TypeScript
187 lines
4.1 KiB
TypeScript
import rule from '@next/eslint-plugin-next/dist/rules/inline-script-id'
|
|
import { RuleTester } from 'eslint'
|
|
;(RuleTester as any).setDefaultConfig({
|
|
parserOptions: {
|
|
ecmaVersion: 2018,
|
|
sourceType: 'module',
|
|
ecmaFeatures: {
|
|
modules: true,
|
|
jsx: true,
|
|
},
|
|
},
|
|
})
|
|
|
|
const errorMessage =
|
|
'`next/script` components with inline content must specify an `id` attribute. See: https://nextjs.org/docs/messages/inline-script-id'
|
|
|
|
const ruleTester = new RuleTester()
|
|
ruleTester.run('inline-script-id', rule, {
|
|
valid: [
|
|
{
|
|
code: `import Script from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<Script id="test-script">
|
|
{\`console.log('Hello world');\`}
|
|
</Script>
|
|
)
|
|
}`,
|
|
},
|
|
{
|
|
code: `import Script from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<Script
|
|
id="test-script"
|
|
dangerouslySetInnerHTML={{
|
|
__html: \`console.log('Hello world');\`
|
|
}}
|
|
/>
|
|
)
|
|
}`,
|
|
},
|
|
{
|
|
code: `import Script from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<Script src="https://example.com" />
|
|
)
|
|
}`,
|
|
},
|
|
{
|
|
code: `import MyScript from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<MyScript id="test-script">
|
|
{\`console.log('Hello world');\`}
|
|
</MyScript>
|
|
)
|
|
}`,
|
|
},
|
|
{
|
|
code: `import MyScript from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<MyScript
|
|
id="test-script"
|
|
dangerouslySetInnerHTML={{
|
|
__html: \`console.log('Hello world');\`
|
|
}}
|
|
/>
|
|
)
|
|
}`,
|
|
},
|
|
{
|
|
code: `import Script from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<Script {...{ strategy: "lazyOnload" }} id={"test-script"}>
|
|
{\`console.log('Hello world');\`}
|
|
</Script>
|
|
)
|
|
}`,
|
|
},
|
|
{
|
|
code: `import Script from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<Script {...{ strategy: "lazyOnload", id: "test-script" }}>
|
|
{\`console.log('Hello world');\`}
|
|
</Script>
|
|
)
|
|
}`,
|
|
},
|
|
{
|
|
code: `import Script from 'next/script';
|
|
const spread = { strategy: "lazyOnload" }
|
|
export default function TestPage() {
|
|
return (
|
|
<Script {...spread} id={"test-script"}>
|
|
{\`console.log('Hello world');\`}
|
|
</Script>
|
|
)
|
|
}`,
|
|
},
|
|
],
|
|
invalid: [
|
|
{
|
|
code: `import Script from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<Script>
|
|
{\`console.log('Hello world');\`}
|
|
</Script>
|
|
)
|
|
}`,
|
|
errors: [
|
|
{
|
|
message: errorMessage,
|
|
type: 'JSXElement',
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `import Script from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<Script
|
|
dangerouslySetInnerHTML={{
|
|
__html: \`console.log('Hello world');\`
|
|
}}
|
|
/>
|
|
)
|
|
}`,
|
|
errors: [
|
|
{
|
|
message: errorMessage,
|
|
type: 'JSXElement',
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `import MyScript from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<MyScript>
|
|
{\`console.log('Hello world');\`}
|
|
</MyScript>
|
|
)
|
|
}`,
|
|
errors: [
|
|
{
|
|
message: errorMessage,
|
|
type: 'JSXElement',
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `import MyScript from 'next/script';
|
|
|
|
export default function TestPage() {
|
|
return (
|
|
<MyScript
|
|
dangerouslySetInnerHTML={{
|
|
__html: \`console.log('Hello world');\`
|
|
}}
|
|
/>
|
|
)
|
|
}`,
|
|
errors: [
|
|
{
|
|
message: errorMessage,
|
|
type: 'JSXElement',
|
|
},
|
|
],
|
|
},
|
|
],
|
|
})
|