c3d1f024a5
This removes the `--net=host` argument passed to the devcontainer. Originally introduced for X11 forwarding, devcontainer already passes `--network host` argument doing the same [thing](https://stackoverflow.com/q/50644889/8429267)? Check the build logs ``` Start: Run: docker run --sig-proxy=false -a STDOUT -a STDERR --mount type=bind,src=/var/lib/docker/codespacemount/workspace,dst=/workspaces --mount source=/root/.codespaces/shared,target=/workspaces/.codespaces/shared,type=bind --mount source=/var/lib/docker/codespacemount/.persistedshare,target=/workspaces/.codespaces/.persistedshare,type=bind --mount source=/.codespaces/agent/mount,target=/.codespaces/bin,type=bind --mount source=/mnt/containerTmp,target=/tmp,type=bind --mount type=bind,src=/.codespaces/agent/mount/cache,dst=/vscode -l Type=codespaces -e CODESPACES=true -e ContainerVersion=12 -e RepositoryName=next.js --label ContainerVersion=12 --hostname codespaces-9b31fb --add-host codespaces-9b31fb:127.0.0.1 --cap-add sys_nice --network host --cap-add SYS_PTRACE --security-opt seccomp=unconfined --entrypoint /bin/sh vsc-next.js-e4966344b9ebb252cd82cad8e4b143f1 -c echo Container started ``` [Refer](https://github.com/vercel/next.js/pull/43138#issuecomment-1328026282) for original issue with the current configuration. Closes #43451 P.S. Why do we have X11 support in devcontainers in the first place? Its not something *most* people will use, especially if it comes with the cost of codespaces not working. Need someone to verify if X11 forwarding still works with this configuration as it probably should.
38 lines
1.5 KiB
JSON
38 lines
1.5 KiB
JSON
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
|
|
// https://github.com/microsoft/vscode-dev-containers/tree/v0.245.0/containers/javascript-node
|
|
{
|
|
"name": "Next.js Dev Container",
|
|
"build": {
|
|
"dockerfile": "Dockerfile",
|
|
// Update 'VARIANT' to pick a Node version: 18, 16, 14.
|
|
// Append -bullseye or -buster to pin to an OS version.
|
|
// Use -bullseye variants on local arm64/Apple Silicon.
|
|
"args": {
|
|
"VARIANT": "16-bullseye"
|
|
}
|
|
},
|
|
// Configure tool-specific properties.
|
|
"customizations": {
|
|
// Configure properties specific to VS Code.
|
|
"vscode": {
|
|
// Add the IDs of extensions you want installed when the container is created.
|
|
"extensions": ["dbaeumer.vscode-eslint"]
|
|
}
|
|
},
|
|
// Use 'forwardPorts' to make a list of ports inside the container available locally.
|
|
// "forwardPorts": [],
|
|
// Use 'postCreateCommand' to run commands after the container is created.
|
|
// "postCreateCommand": "yarn install",
|
|
// Comment out to connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
|
|
"remoteUser": "node",
|
|
"features": {
|
|
// For some reason "git" or "rust" doesn't work
|
|
"ghcr.io/devcontainers/features/git:1": "os-provided",
|
|
"ghcr.io/devcontainers/features/rust:1": "latest"
|
|
// Github latest can't be installed due to GPG issues: https://github.com/cli/cli/discussions/6222
|
|
// "github-cli": "latest",
|
|
},
|
|
"remoteEnv": {
|
|
"DISPLAY": ":0"
|
|
}
|
|
}
|