archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rsnext/test
History
Naoyuki Kanezawa eb878459de
fix post request hangs when no body is consumed on middleware (#35131) 
fixes https://github.com/vercel/next.js/issues/34966

Wait for reading original request body before overwriting the request properties with `originalBody?.finalize()` call since it caused the problem when middleware does not read request body

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`
2022-03-08 19:24:58 +00:00
..
.stats-app remove commons chunk config (#34445) 2022-02-19 22:26:54 +00:00
development feat: allow dotenv default expansion (#34765) 2022-03-03 16:52:20 +00:00
e2e Handle de-duping revalidations in minimal mode (#34935) 2022-03-02 15:06:54 -08:00
integration [next] Fix to not call middleware with shallow push, fix middleware call wit… (#35047) 2022-03-08 19:03:14 +00:00
lib test: add inline flight response reuse test (#34364) 2022-02-15 18:53:45 +00:00
production fix post request hangs when no body is consumed on middleware (#35131) 2022-03-08 19:24:58 +00:00
unit Fix next/image noscript when blur and priority (#34973) 2022-03-02 19:59:02 +00:00
.gitignore Universal Webpack (#3578) 2018-01-30 16:44:44 +01:00
jest-setup-after-env.ts Update azure config (#33999) 2022-02-04 13:42:22 -06:00
readme.md [docs] Fix 404 link for testing example. (#33407) 2022-01-17 19:08:52 +00:00
test-file.txt Add additional file serving tests (#12479) 2020-05-04 11:58:19 -05:00

readme.md

Writing tests for Next.js

Getting Started

You can set-up a new test using yarn new-test which will start from a template related to the test type.

Test Types in Next.js

  • e2e: These tests will run against next dev and next start
  • development: These tests only run against next dev
  • production: These tests will run against next start.
  • integration: These tests run misc checks and modes and is where tests used to be added before we added more specific folders. Ideally we don't add new test suites here as tests here are not isolated from the monorepo.
  • unit: These are very fast tests that should run without a browser or running next and should be testing a specific utility.

For the e2e, production, and development tests the createNext utility should be used and an example is available here. This creates an isolated Next.js install to ensure nothing in the monorepo is relied on accidentally causing incorrect tests.

All new test suites should be written in TypeScript either .ts (or .tsx for unit tests). This will help ensure we catch smaller issues in tests that could cause flakey or incorrect tests.

If a test suite already exists that relates closely to the item being tested (e.g. hash navigation relates to existing navigation test suites) the new checks can be added in the existing test suite.

Best Practices

  • When checking for a condition that might take time, ensure it is waited for either using the browser waitForElement or using the check util in next-test-utils.
  • When applying a fix, ensure the test fails without the fix. This makes sure the test will properly catch regressions.