f354f46b3f
This PR deprecates declaring a middleware under `pages` in favour of the project root naming it after `middleware` instead of `_middleware`. This is in the context of having a simpler execution model for middleware and also ships some refactor work. There is a ton of a code to be simplified after this deprecation but I think it is best to do it progressively. With this PR, when in development, we will **fail** whenever we find a nested middleware but we do **not** include it in the compiler so if the project is using it, it will no longer work. For production we will **fail** too so it will not be possible to build and deploy a deprecated middleware. The error points to a page that should also be reviewed as part of **documentation**. Aside from the deprecation, this migrates all middleware tests to work with a single middleware. It also splits tests into multiple folders to make them easier to isolate and work with. Finally it ships some small code refactor and simplifications.
69 lines
1.8 KiB
TypeScript
69 lines
1.8 KiB
TypeScript
import { createNext } from 'e2e-utils'
|
|
import { NextInstance } from 'test/lib/next-modes/base'
|
|
import fs from 'fs-extra'
|
|
import path from 'path'
|
|
|
|
describe('experimental.middlewareSourceMaps: true', () => {
|
|
let next: NextInstance
|
|
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
nextConfig: {
|
|
experimental: {
|
|
middlewareSourceMaps: true,
|
|
},
|
|
},
|
|
files: {
|
|
'pages/index.js': `
|
|
export default function () { return <div>Hello, world!</div> }
|
|
`,
|
|
'middleware.js': `
|
|
export default function middleware() {
|
|
return new Response("Hello, world!");
|
|
}
|
|
`,
|
|
},
|
|
dependencies: {},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it('generates a source map', async () => {
|
|
const middlewarePath = path.resolve(
|
|
next.testDir,
|
|
'.next/server/middleware.js'
|
|
)
|
|
expect(await fs.pathExists(middlewarePath)).toEqual(true)
|
|
expect(await fs.pathExists(`${middlewarePath}.map`)).toEqual(true)
|
|
})
|
|
})
|
|
|
|
describe('experimental.middlewareSourceMaps: false', () => {
|
|
let next: NextInstance
|
|
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: {
|
|
'pages/index.js': `
|
|
export default function () { return <div>Hello, world!</div> }
|
|
`,
|
|
'middleware.js': `
|
|
export default function middleware() {
|
|
return new Response("Hello, world!");
|
|
}
|
|
`,
|
|
},
|
|
dependencies: {},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it('does not generate a source map', async () => {
|
|
const middlewarePath = path.resolve(
|
|
next.testDir,
|
|
'.next/server/middleware.js'
|
|
)
|
|
expect(await fs.pathExists(middlewarePath)).toEqual(true)
|
|
expect(await fs.pathExists(`${middlewarePath}.map`)).toEqual(false)
|
|
})
|
|
})
|