a720dbdc4c
Fixes: #38232 Fixes: https://github.com/vercel/next.js/issues/36893 Version [12.1.1-canary.5](https://github.com/vercel/next.js/releases/tag/v12.1.1-canary.5) introduced a bug, more specifically this PR: https://github.com/vercel/next.js/pull/34836 The issue described in #38232 is that the following code starts both the dev and prod servers: ```js const start = require('next/dist/cli/next-start') start.nextStart() ``` I searched a bit and found that `lib/get-project-dir.ts#getProjectDir()` now imports `bin/next.ts`6b8e499c7b/packages/next/lib/get-project-dir.ts (L3)and it calls a CLI command via6b8e499c7b/packages/next/bin/next.ts (L137)This `command` should not be defined, but it fallbacks to `defaultCommand`, which is `dev` (that explains why the dev server is also started) This PR moves the `cliCommand` types and `commands` variable to a new separate file instead of `bin/next.ts`, to avoid running a CLI command when we import any file that also imports `lib/get-project-dir.ts` Not sure how integration tests can be added for this issue, but feel free to tell me. Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
78 lines
2 KiB
JavaScript
Executable file
78 lines
2 KiB
JavaScript
Executable file
#!/usr/bin/env node
|
|
import { resolve, join } from 'path'
|
|
import { existsSync } from 'fs'
|
|
import arg from 'next/dist/compiled/arg/index.js'
|
|
import exportApp from '../export'
|
|
import { printAndExit } from '../server/lib/utils'
|
|
import { cliCommand } from '../lib/commands'
|
|
import { trace } from '../trace'
|
|
import isError from '../lib/is-error'
|
|
import { getProjectDir } from '../lib/get-project-dir'
|
|
|
|
const nextExport: cliCommand = (argv) => {
|
|
const nextExportCliSpan = trace('next-export-cli')
|
|
const validArgs: arg.Spec = {
|
|
// Types
|
|
'--help': Boolean,
|
|
'--silent': Boolean,
|
|
'--outdir': String,
|
|
'--threads': Number,
|
|
|
|
// Aliases
|
|
'-h': '--help',
|
|
'-s': '--silent',
|
|
'-o': '--outdir',
|
|
}
|
|
let args: arg.Result<arg.Spec>
|
|
try {
|
|
args = arg(validArgs, { argv })
|
|
} catch (error) {
|
|
if (isError(error) && error.code === 'ARG_UNKNOWN_OPTION') {
|
|
return printAndExit(error.message, 1)
|
|
}
|
|
throw error
|
|
}
|
|
if (args['--help']) {
|
|
console.log(`
|
|
Description
|
|
Exports the application for production deployment
|
|
|
|
Usage
|
|
$ next export [options] <dir>
|
|
|
|
<dir> represents the directory of the Next.js application.
|
|
If no directory is provided, the current directory will be used.
|
|
|
|
Options
|
|
-h - list this help
|
|
-o - set the output dir (defaults to 'out')
|
|
-s - do not print any messages to console
|
|
`)
|
|
process.exit(0)
|
|
}
|
|
|
|
const dir = getProjectDir(args._[0])
|
|
|
|
// Check if pages dir exists and warn if not
|
|
if (!existsSync(dir)) {
|
|
printAndExit(`> No such directory exists as the project root: ${dir}`)
|
|
}
|
|
|
|
const options = {
|
|
silent: args['--silent'] || false,
|
|
threads: args['--threads'],
|
|
outdir: args['--outdir'] ? resolve(args['--outdir']) : join(dir, 'out'),
|
|
}
|
|
|
|
exportApp(dir, options, nextExportCliSpan)
|
|
.then(() => {
|
|
nextExportCliSpan.stop()
|
|
printAndExit(`Export successful. Files written to ${options.outdir}`, 0)
|
|
})
|
|
.catch((err) => {
|
|
nextExportCliSpan.stop()
|
|
printAndExit(err)
|
|
})
|
|
}
|
|
|
|
export { nextExport }
|