archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-22 12:21:41 +02:00
Code Issues Projects Releases Packages Wiki Activity
27671 commits 5 branches 11 tags 1.3 GiB
Commit graph

23850 commits

Author SHA1 Message Date
spycrab
40a61e7bf5 Qt: Deduplicate settings 2018-04-22 22:26:28 +02:00
container1234
41844c1cc5 Qt/Debugger: Change the row height to same as code/memory widget 2018-04-23 00:52:31 +09:00
container1234
32f6d3f62b Qt: Use HostRead for float and double 2018-04-23 00:46:42 +09:00
Pierre Bourdon
1b63810e85
Merge pull request #6684 from spycrab/qt_wrong_thread 
Qt/Settings: Emit EmulationStateChanged from the UI thread
 2018-04-22 15:36:32 +02:00
spycrab
854fa0f093 Qt/Settings: Emit EmulationStateChanged from the UI thread 2018-04-22 13:04:48 +02:00
spycrab
519fa7529f Qt/RenderWidget: Fix the render widget showing up when it shouldn't 2018-04-22 13:01:18 +02:00
spycrab
caa18edc79 Qt: Implement "Keep Window on top" 2018-04-22 11:15:39 +02:00
spycrab
c1dccdc0e5 Qt/RenderWidget: Fix getting painted over 2018-04-22 10:15:09 +02:00
spycrab
b059b3a646 Qt: Pause on focus loss 2018-04-22 10:15:09 +02:00
Tilka
c131b7c3b4
Merge pull request #6682 from spycrab/qt_minor_fixes 
Qt: Minor fixes
 2018-04-22 08:12:42 +01:00
aldelaro5
2f6879f0d9
Qt/log change the notice log color to lime 
It's slightly easier to read than green
 2018-04-21 21:22:16 -04:00
spycrab
7b35c8577a Qt: Fix crashes when closing render window 2018-04-21 23:27:54 +02:00
spycrab
b2e5f1d85f Qt/GeneralPane: Disable certain options while emulation is running 2018-04-21 22:09:46 +02:00
Léo Lam
9dcc8131df
Merge pull request #6331 from spycrab/deprecate_wx 
[RFC] Qt/Wx: Turn Qt into the default interface
 2018-04-21 18:36:10 +02:00
spycrab
694df74b0b Qt/Wx: Turn Qt into the default interface 2018-04-21 17:54:00 +02:00
Tilka
7dc16efc9d
Merge pull request #6675 from spycrab/qt_recursive 
Qt: Add "Search subdirectories" checkbox
 2018-04-21 16:07:02 +01:00
spycrab
a4526772b9 Qt: Add "Search subdirectories" checkbox 2018-04-21 00:14:55 +02:00
Léo Lam
dabfecfd74
Merge pull request #6672 from spycrab/qt_dynamic 
Qt: Make toolbar more dynamic
 2018-04-20 23:41:51 +02:00
spycrab
264c995b0d Qt: Make toolbar more dynamic 2018-04-20 22:44:49 +02:00
Léo Lam
2fcc633c28
Merge pull request #6649 from leoetlino/fs-tests 
UnitTests: Add tests for the Wii filesystem
 2018-04-20 21:34:06 +02:00
Tilka
4c8de9638a
Merge pull request #6674 from Tilka/jit64 
Jit64: avoid an unnecessary load
 2018-04-20 19:23:28 +01:00
Léo Lam
bc7bf97f14
Merge pull request #6666 from Ebola16/ASU2 
Update Android Gradle Plugin
 2018-04-20 18:18:22 +02:00
Léo Lam
f9340424c8
Merge pull request #6669 from lioncash/thread-local 
Core: Use thread_local directly
 2018-04-20 18:11:32 +02:00
Léo Lam
1176ae6512 IOS/FS: Fix ReadDirectory file list copying 
Each entry can take up to 13 bytes (including the terminating null
character) but should not be aligned to 13 bytes.
 2018-04-20 00:02:32 +02:00
Léo Lam
4c47417a0e IOS/FS: Fix ReadDir returning wrong number of entries 
ReadDir should always write the actual number of entries in the
directory list (`min(max_count, number_of_entries_on_nand)`).
 2018-04-20 00:02:32 +02:00
Tilka
a500347345
Merge pull request #6676 from spycrab/qt_fix_open 
Qt: Fix "Open File" dialog opening twice
 2018-04-19 22:13:38 +01:00
spycrab
cd390714c9 Qt: Fix "Open File" dialog opening twice 2018-04-19 23:10:23 +02:00
Tillmann Karras
1737f1bee8 Jit64: avoid an unnecessary load 2018-04-19 21:49:12 +01:00
spycrab
c09075209f Qt: Implement Cheats Manager 2018-04-19 10:42:24 +02:00
Léo Lam
396204248d
Merge pull request #6667 from lioncash/si 
SI: Remove unnecessary declarations of internally linked functions
 2018-04-18 18:49:44 +02:00
Lioncash
e6405f7b2b
Core: Use thread_local directly 
Both Android and OSX now support it, allowing us to remove the fallback code.
 2018-04-17 19:03:24 -04:00
Mat M
df44aa7335
Merge pull request #6668 from JosJuice/remove-hybrid-wiimote 
Remove Hybrid Wii Remote
 2018-04-17 18:09:58 -04:00
Ryan Meredith
b00c29b70d Update Android Gradle Plugin 2018-04-17 16:54:14 -04:00
JosJuice
2953cf201d Remove Hybrid Wii Remote 
It simply doesn't seem to work for anything useful, and nobody seems
to care about maintaining it.
 2018-04-17 22:40:21 +02:00
Lioncash
d1d8300a46
SI: Remove unnecessary declarations of internally linked functions 
These aren't dependent on calling order so we can just organize all of the statics together
instead of splitting them up over the file. This also allows us to organize a common spot for
file static variables as well.
 2018-04-17 16:33:11 -04:00
Mat M
d230194464
Merge pull request #6657 from leoetlino/dedup 
Qt/Debugger: Deduplicate memory view update code
 2018-04-17 10:21:53 -04:00
Mat M
b19d77a3ff
Merge pull request #6660 from leoetlino/pause 
Qt/Debugger: Don't pause when already paused
 2018-04-17 10:20:30 -04:00
Mat M
e04592e6c4
Merge pull request #6663 from spycrab/qt_fix_columns 
Qt: Fix columns not properly showing / hiding
 2018-04-17 10:19:35 -04:00
Mat M
8bb0e0ee96
Merge pull request #6662 from Tilka/fix_warnings 
Fix some warnings
 2018-04-17 10:17:01 -04:00
spycrab
9ffc600e8d Qt: Fix columns not properly showing / hiding 2018-04-17 15:27:51 +02:00
Tillmann Karras
4cfd900c67 Fix some warnings 2018-04-17 14:10:05 +01:00
Sepalani
04cfddca33 HLE_VarArgs: PowerPC::HostRead_F64 used 2018-04-17 16:25:43 +04:00
Léo Lam
69ad94997c Qt/Debugger: Don't pause when already paused 
Fixes a severe performance issue which would cause the UI to use tons
of CPU time and fail to update when scrolling with a breakpoint on PC.
 2018-04-17 14:21:18 +02:00
Mat M
c78b3f6ab6
Merge pull request #4507 from sepalani/host_f 
PowerPC: HostR/W float/double added
 2018-04-17 08:02:07 -04:00
Pierre Bourdon
94f3e27ccd
Merge pull request #6659 from spycrab/qt_tabbed_config 
Qt/SettingsWindow: Use tabs
 2018-04-17 13:52:23 +02:00
Sepalani
048513183e PowerPC: HostR/W float/double added 2018-04-17 08:29:47 +04:00
spycrab
4d4a018ccf Qt/SettingsWindow: Use tabs 2018-04-16 23:15:45 +02:00
Lioncash
c23a998f9d
TraversalClient: Use u32 instead of enet_uint32 
Lessens the dependence on the enet library (and we really don't need to rely on a third-party library for a 32-bit integer type)
 2018-04-16 16:46:48 -04:00
Lioncash
f1e92a1eae
TraversalClient: Make TestPacket() private 
This is only used by the private InterceptCallback()
 2018-04-16 16:46:48 -04:00
Lioncash
1b8ad49d1e
TraversalClient: In-class initialize members where applicable 2018-04-16 16:46:48 -04:00
Lioncash
ca6a2970ea
TraversalClient: Make data externally read-only members private 
These are only ever queried for state, not written. Therefore, prevent writing to the members
and make them private.
 2018-04-16 16:46:44 -04:00
Léo Lam
6c87817d9c Qt/Debugger: Deduplicate memory view update code 
The structure and address calculation were identical.
Only the string generation was different.
 2018-04-16 22:36:32 +02:00
Léo Lam
dfd6a228a6
Merge pull request #6654 from lioncash/log 
Common/Logging/Log: Wrap GENERIC_LOG macro's body in do { } while (0)
 2018-04-16 20:38:22 +02:00
Léo Lam
d13fc1d2e9
Merge pull request #6655 from lioncash/common-libs 
Common/CMakeLists: Link curl and VTune libraries in privately
 2018-04-16 20:35:31 +02:00
JosJuice
0efbaebe17 Minor fixes to translatable strings 
The usual deduplication between DolphinWX and DolphinQt2, plus the removal
of a now unused ubershader string and a fix for the Euphoria i18n comment.
 2018-04-16 19:08:58 +02:00
Lioncash
236aed9fd1
Common/CMakeLists: Link curl and VTune libraries in privately 
These are only used internally.
 2018-04-16 12:38:24 -04:00
Lioncash
b0dc823472
Common/Logging/Log: Wrap GENERIC_LOG macro's body in do { } while (0) 
Enforces the termination of GENERIC_LOGs with semicolons.
 2018-04-16 12:11:32 -04:00
Mat M
6224b9bd37
Merge pull request #6642 from leoetlino/stm 
IOS/STM: Reset the event hook at the correct time
 2018-04-16 09:04:12 -04:00
Lioncash
939c5671a9 Common/Config: Remove unused header inclusions 2018-04-15 22:35:00 -04:00
Lioncash
4836739663 Common/Config: Remove unnecessary function declaration 
This prototype declaration is already provided by the Config.h header
 2018-04-15 22:33:53 -04:00
Léo Lam
3355ddcfb3 FileSystem: Fix member destruction order 2018-04-15 14:29:27 +02:00
Léo Lam
45647df349 UnitTests: Add tests for the Wii filesystem 
This adds unit tests for the Wii filesystem now that the filesystem
interface is neatly separated from the IPC code.

Basic FS functionality is tested, in addition to problematic usages and
edge cases that Dolphin used to handle incorrectly (which of course
broke emulated software).

These tests should make it quite a bit harder to introduce regressions.

Issues that are covered by the tests in particular:

* Metadata: issue 10234 (though tests are commented out for now because
  Dolphin doesn't support NAND images yet so it can't track metadata);

* EOF seeks/reads: https://github.com/dolphin-emu/dolphin/pull/4942

* Read/write operations from multiple handles: see issue 2917, 5232 and
  8702 and https://github.com/dolphin-emu/dolphin/pull/2649
 2018-04-15 14:29:27 +02:00
Mat M
eecdb51709
Merge pull request #6645 from JosJuice/tie-constexpr 
x64Emitter: Don't assume that std::tie is constexpr
 2018-04-15 03:11:31 -04:00
JosJuice
8a146d5210 x64Emitter: Don't assume that std::tie is constexpr 
Using constexpr tie broke building with older GCC versions according to
https://forums.dolphin-emu.org/Thread-build-error-on-linux-mint-18-3
 2018-04-15 08:30:01 +02:00
JosJuice
45923696ed
Merge pull request #6648 from leoetlino/master 
WiimoteEmu: Fix turntable_button_names size
 2018-04-15 08:25:44 +02:00
Mat M
615c0decb7
Merge pull request #6644 from leoetlino/uicommon-header 
UICommon: Fix header
 2018-04-14 20:25:22 -04:00
Léo Lam
0a481c0663 WiimoteEmu: Fix turntable_button_names size 
Three elements were removed, but because of an oversight the array
size was not changed to match.
 2018-04-14 23:52:10 +02:00
Léo Lam
783e4ec2fa
Merge pull request #6633 from aldelaro5/wx-debugger-icons 
Wx: debugger icons
 2018-04-14 23:29:57 +02:00
Léo Lam
371f807e67
Merge pull request #6615 from leoetlino/sysconf 
SysConf: Migrate to new filesystem interface
 2018-04-14 23:29:25 +02:00
Léo Lam
c73b05e200
Merge pull request #6647 from aldelaro5/qt-fix-mbp 
Qt/Debugger: correctly set the MBP attributes when adding an address one
 2018-04-14 23:22:57 +02:00
aldelaro5
0f8c51dfe4
Wx: Implement the new debugger icons 2018-04-14 17:22:04 -04:00
Léo Lam
ee955e37a9
Merge pull request #6564 from JosJuice/translate-certain-button-names 
Translate certain button names but not all
 2018-04-14 23:20:39 +02:00
Léo Lam
aafa8a10e1
Merge pull request #6643 from lioncash/oprofile 
CMakeLists: Define an OProfile target and use it
 2018-04-14 23:12:17 +02:00
aldelaro5
1401fbc71a
Qt/Debugger: correctly set the MBP attributes when adding 
Not setting the end address causes the GetMecheck function to never think a matching address MBP exists.
 2018-04-14 17:05:23 -04:00
Léo Lam
2f22c76db1 UICommon: Avoid including Xrandr.h 
Xlib has really terrible headers that declare non-namespaced
macros and typedefs for common words.

Just wasted 10 minutes trying to figure out why a unit test failed
to build before I remembered it was Xrandr.h conflicting with our
enum class members again.

To fix the issue, this removes the Display* parameter from the
EnableScreensaver function (which was unused) so we don't have
to include Xrandr.h anymore.
 2018-04-14 17:14:38 +02:00
Léo Lam
62269572e4 UICommon: Fix indirect includes 2018-04-14 16:42:54 +02:00
Léo Lam
e253d3d919
Merge pull request #6640 from spycrab/qt_scale_render 
Qt: Fix render size not matching window size
 2018-04-14 14:56:33 +02:00
Lioncash
b31281527a
CMakeLists: Define an OProfile target and use it 
Allows us to bring includes and relevant libraries into scope by explicitly declaring linkage against the target
as opposed to using a variable. Also removes the dumping of OProfile includes into the top-level directory.
 2018-04-13 19:35:17 -04:00
Léo Lam
8bae4b7e51 IOS/STM: Reset the event hook at the correct time 
Just re-disassembled STM and found out I have made a mistake when
I changed STM stuff back in 2016.

I accidentally made STM reset the event hook on close when it should
have been done in the destructor (i.e. when IOS gets reset on console).

Verified in IDA that STM just `IOS_ResourceReply(request, IOS_OK)`
without ever resetting the hook.
 2018-04-13 23:34:35 +02:00
Léo Lam
b1bbd8a50e
Merge pull request #6625 from lioncash/evdev-udev 
InputCommon/CMakeLists: Include evdev and udev includes on a by-target basis
 2018-04-13 20:50:31 +02:00
Léo Lam
52905a5fae
Merge pull request #6627 from sepalani/map-strip 
PPCSymbolDB: Do not truncate fixed size symbols
 2018-04-13 20:48:28 +02:00
spycrab
a12d4996ed Qt: Use new debugger icons 2018-04-13 20:40:41 +02:00
spycrab
8536e31136 Qt: Fix render size not matching window size 2018-04-13 20:12:13 +02:00
Lioncash
b256f873ca
CMakeLists: Link in zlib privately where applicable 
Also, use the target name introduced via find_package(ZLIB) instead
of hardcoding the 'z' name in the link libraries.
 2018-04-13 08:29:46 -04:00
JosJuice
7ed28297b2 ControllerEmu: Use enum instead of bool for translatability 2018-04-13 13:04:26 +02:00
JosJuice
3f13dbe087 Translate certain button names but not all 
Some button names should be translated, for instance Up, Left and such.
At the same time, some other button names shouldn't be translated,
for reasons that might be less obvious. In 0146456af, I removed the
_trans markers for button names that never need to be translated
(such as A and B), but that isn't actually enough to ensure that
DolphinWX won't try to translate them anyway. This commit adds a bool
that explicitly tells the GUI whether a button name should be translated.
Otherwise we'll have problems like the GUI treating the button name "B"
(which isn't supposed to be translated) as matching the translatable
string "B" (being an abbreviation of "bytes"), meaning that the button
"B" will be labeled "o" when running Dolphin in French (after
translations get pulled from Transifex the next time).

By the way, while it turned out that DolphinWX translated all button
names, it also turned out that DolphinQt2 translated *no* button names.
Go figure. This commit makes them consistent with each other.
 2018-04-13 13:04:26 +02:00
JosJuice
e604641b12 Remove leftovers of projection hack support 2018-04-13 12:52:42 +02:00
Markus Wick
71dd2d9d4c
Merge pull request #6632 from lioncash/fp 
Interpreter: Don't use a union to type-pun between integral and FP types
 2018-04-13 11:12:01 +02:00
Lioncash
e28d063539 x64Emitter: Make the Align* functions return a non-const data pointer 
There's no real requirement to make this const, and this should also
be decided by the calling code, considering we had places that would
simply cast away the const and carry on.
 2018-04-12 19:46:55 -04:00
Lioncash
ab25eb6449 Interpreter_LoadStorePaired: Don't use a union to type-pun between integral and FP types 2018-04-12 19:44:31 -04:00
Lioncash
7a3158a693 Interpreter_FPUtils: Don't use a union to type-pun between integral and FP types 
The previous code invokes undefined behavior. memcpy will optimize away
to the relevant loads and stores while maintaining well-defined
behavior.
 2018-04-12 19:44:31 -04:00
Tilka
bbd1bb8eaa
Merge pull request #6636 from phire/fix_autoformatting 
Fix change in comment meaning by autoformat.
 2018-04-12 22:52:06 +01:00
Scott Mansell
0e6d01220a Fix change in comment meaning by autoformat. 2018-04-13 09:20:27 +12:00
Tilka
27515f4c9b
Merge pull request #6626 from lioncash/dcbz_l-disasm 
GekkoDisassembler: Fix disassembly of dcbz_l
 2018-04-12 22:18:56 +01:00
Léo Lam
a287bbc3bd Move SysConf to Core 
It's not common code that could be reused for, say, Citra;
it's absolutely specific to Wii emulation and only used by the Dolphin
core, so let's move it there.

Another reason for doing this is to avoid having Common depend on Core.
 2018-04-12 22:16:37 +02:00
Léo Lam
0856d4a68a SysConf: Migrate to new filesystem interface 
It was discovered that some titles rely on filesystem metadata to work
properly. Currently, in master they either simply won't find their
save files (for example Bolt) or will complain about the Wii system
memory being corrupted (on first use or every time depending on
the title).

In order to even be able to keep track of file metadata, we first need
to eliminate all direct accesses to the NAND and make all kinds of
operations go through the filesystem code added in PR 6421.

This commit starts the migration process by making SysConf use
the new FS interface.
 2018-04-12 22:16:37 +02:00
Léo Lam
3744a6d3f5 FileSystem: Add some more wrappers for convenience 2018-04-12 22:16:37 +02:00
Léo Lam
95aae11164 IOS: Do not manually close devices in destructor 
This used to be necessary for properly cleaning up the FS state because
the old FS implementation used static state and only performed cleanup
in the close function, not in the destructor.

Now that the static state is gone, we do not need to close devices
manually anymore.
 2018-04-12 22:16:10 +02:00
spycrab
40bb9974f2 Reformat all the things! 2018-04-12 21:28:39 +02:00
Sepalani
7d36165489 PPCSymbolDB: Do not truncate fixed size symbols 
Fix comparison warning
 2018-04-10 21:50:33 +04:00
Sepalani
9b8866ba78 PPCSymbolDB: Replace alert with LOG message 2018-04-10 21:49:47 +04:00
Lioncash
1c17329e2f
GekkoDisassembler: Fix disassembly of dcbz_l 
Previously this would fall through and disassemble as a generic "ps_[number]" junk instruction.
 2018-04-10 11:22:01 -04:00
Lioncash
73ebc190fa
InputCommon/CMakeLists: Link evdev and udev in privately 
These libraries aren't directly used outside of InputCommon
 2018-04-10 09:59:55 -04:00
Lioncash
d63d0b5069
InputCommon/CMakeLists: Include evdev and udev includes on a by-target basis 
Avoids including the evdev/udev includes in the top-level directory
 2018-04-10 09:59:51 -04:00
Markus Wick
0bfeb37a1f
Merge pull request #6604 from lioncash/dcbz_l 
Interpreter_LoadStore: Generate a program exception if dcbz_l is executed when HID2[LCE] is zero
 2018-04-09 23:04:09 +02:00
JosJuice
a66d56aece Use configured locale in UICommon::FormatSize 
StringFromFormat always uses the C locale, so we can't use it if we want
the decimal separator to be locale aware, but we can use a stringstream.
 2018-04-09 19:14:15 +02:00
JosJuice
0dca432836 Remove old code for using default locale 
This isn't needed anymore now that the global C++ locale isn't
set to the classic locale.
 2018-04-09 19:14:15 +02:00
JosJuice
13d060491c DolphinQt2: Set locale 
We want things like number formatting to be done the way the user expects.
 2018-04-09 19:14:14 +02:00
JosJuice
72040600d7 Set locale to "en_GB" if "en" is configured 2018-04-09 19:14:14 +02:00
JosJuice
9417fc6a3a DolphinWX: Set C++ locale 
After 3a83ebc, the Show System Clock feature started using the
unfortunate combination of MM/DD/YY dates (rare outside of the US)
and 24-hour time (rare in the US) regardless of the user's locale
settings. This commit makes it use the configured locale again.

I've noticed one minor difference in behavior between now and
before 3a83ebc: The new way of setting the C/C++ locale seems to
treat "en" as "en-US", but the wx way of setting the C locale
treated it as "en-GB" (at least on Windows).
 2018-04-09 19:14:14 +02:00
JosJuice
7aaaf44229
Merge pull request #6611 from leoetlino/remove-workaround 
Boot_WiiWAD: Remove a timing issue workaround
 2018-04-09 15:46:39 +02:00
Léo Lam
67f8e6e60a
Merge pull request #6620 from lioncash/dvd 
DVDInterface: Deduplicate code in UpdateInterrupts()
 2018-04-09 12:52:38 +02:00
Léo Lam
cb88e1256f
Merge pull request #6617 from lioncash/ppcanalyst 
PPCAnalyst: Minor cleanup
 2018-04-09 12:48:16 +02:00
Léo Lam
783cbef638
Merge pull request #6618 from lioncash/symboldb 
PPCSymbolDB: Minor cleanup
 2018-04-09 12:46:28 +02:00
Lioncash
1b3dae918a StreamADPCM: Turn the ADPCM decoder into a class 
Migrates the state to be instance-based as opposed to being a flat
namespace. This keeps behavior localized to its own instantiable unit
(and forces uses of the class to also be localized, lest they cart around
an instance all over the place).
 2018-04-09 03:49:18 -04:00
Lioncash
a8088b7365 ProcessorInterface: Remove prefixed underscores from parameters 
These are reserved by the implementation for any use.
 2018-04-09 03:21:59 -04:00
Lioncash
419ed1b46a DVDInterface: Deduplicate code in UpdateInterrupts() 2018-04-09 03:18:51 -04:00
Lioncash
a0f943178b Profiler: Move BlockStat and ProfileStats structures into the Profiler namespace 
These should be part of the namespaced API and not be sitting in the
global namespace.
 2018-04-08 22:29:48 -04:00
Lioncash
0461709c8d PPCSymbolDB: Use auto for iterators where applicable 2018-04-08 22:03:11 -04:00
Lioncash
b44eb90ee4 PPCSymbolDB: Default destructor and pass to member variables in the constructor initializer-list 2018-04-08 21:56:24 -04:00
Lioncash
d6d17eea60 PPCSymbolDB: Remove unused function pointer typedef 2018-04-08 21:54:50 -04:00
Lioncash
9c5115a627 PPCAnalyst: Simplify boolean assignments in SetInstructionStats() 
Ternaries here aren't necessary if all we're checking against is if
something is non-zero
 2018-04-08 21:42:43 -04:00
Lioncash
f2b2f5b4c7 PPCAnalyst: Make ReorderType an enum class 
Makes the values strongly typed and doesn't dump them into the class
itself.
 2018-04-08 21:38:19 -04:00
Lioncash
5e5a56bd9b PPCAnalyst: Remove unnecessary includes from header 2018-04-08 21:34:12 -04:00
Lioncash
4bd3b28823 PPCAnalyst: in-class initialize PPCAnalyzer's members 
Eliminates the need to assign in the constructor initializer list.
 2018-04-08 21:32:15 -04:00
Lioncash
433a56636b PPCAnalyst: Move public interface above private interface 2018-04-08 21:31:19 -04:00
Léo Lam
8894b902df Boot_WiiWAD: Remove a timing issue workaround 
This was necessary to work around a FS timing issue which caused small
writes to take much longer than they should.

Now that we emulate timings for the FS module including its file cache,
we don't need to maintain this workaround anymore.
 2018-04-08 11:23:18 +02:00
Léo Lam
9dbc760bb7
Merge pull request #6606 from lioncash/bochs 
CMakeLists: Link bochs in privately where applicable
 2018-04-08 11:08:12 +02:00
Lioncash
f1be7cd4a0
CMakeLists: Link bochs in privately where applicable 
Everything that links in core doesn't need to see anything related to bochs, because it's only used internally.
Anything else that relies on bochs should be linking it in explicitly.
 2018-04-08 04:59:58 -04:00
Léo Lam
0a290f5d11
Merge pull request #6607 from lioncash/ppc 
PPCDebugInterface: Remove redundant HostRead_U32() call in Disassemble()
 2018-04-08 10:25:43 +02:00
Léo Lam
2a535d5a55
Merge pull request #6608 from lioncash/gekko 
Gekko: In-class initialize members where applicable
 2018-04-08 10:23:42 +02:00
Léo Lam
219728dbd4
Merge pull request #6609 from lioncash/ufpr 
Gekko: Remove unused UFPR union
 2018-04-08 10:22:43 +02:00
Lioncash
88a80f118c Common/Swap: Amend BigEndianValue's operator= to return a reference to the object rather than returning void 
The general convention is to return a reference to the object that was
acted on, otherwise you can get into situations with errors because the
type wasn't being propagated properly
 2018-04-08 01:22:18 -04:00
Lioncash
5d1349f9c7 Gekko: Remove unused UFPR union 
Using this in its current form would invoke undefined behavior, as it's
using a union to type pun between data types. It's also, well, unused,
so we don't need to keep it around.
 2018-04-07 22:30:26 -04:00
Lioncash
d5555b49e9 Gekko: In-class initialize members where applicable 
Allows defaulting the default constructor. Also moves assignment to
initializer lists where applicable as well.
 2018-04-07 22:26:24 -04:00
Lioncash
3e50b0e320 PPCDebugInterface: Remove redundant HostRead_U32() call in Disassemble() 
We already read the necessary information with the
HostRead_Instruction() call. Internally, it calls HostRead_U32() as
well, so there's no difference in behavior.
 2018-04-07 22:20:59 -04:00
Léo Lam
f4a2ad3c88 IOS/FS: Emulate read/write/close/seek timing 
Also bumps up the state version.
 2018-04-07 23:35:28 +02:00
Léo Lam
42983c0bd3 IOS/FS: Emulate superblock write timing 2018-04-07 23:35:28 +02:00
Léo Lam
b74577ff43 IOS/FS: Emulate GetAttr() timing 2018-04-07 23:35:28 +02:00
Léo Lam
896d875187 IOS/FS: Emulate Open() timing 2018-04-07 23:35:28 +02:00
Léo Lam
32b1409cbd IOS/FS: Use hardware tested minimum reply time 
...instead of an arbitrary guess.
 2018-04-07 23:35:28 +02:00
Léo Lam
7dff069659
Merge pull request #6605 from spycrab/gc_fix_rumble 
[RFC] Core/GC: Fix rumble for "Luigi's Mansion"
 2018-04-07 23:23:30 +02:00
spycrab
eed066e8a7 Core/GC: Fix rumble for "Luigi's Mansion" 2018-04-07 22:13:01 +02:00
Lioncash
181539e049
Interpreter_LoadStore: Generate a program exception if dcbz_l is executed when HID2[LCE] is zero 
If the locked cache isn't enabled, dcbz_l is illegal to execute
(locked cache is off, locked cache instructions don't work, makes sense)

This makes exception handling more accurate. It was previously possible to hit the DSI exception
handler when HID2[LCE] is set to zero, which isn't correct.

With this change we no longer hit the DSI handler, however we still have a lingering issue elsewhere
likely to do with exception precedence, we seem to hit the Floating Point exception handler instead
in some cases. This isn't due to the instruction itself directly however, so this is just another bug
to fix elsewhere.
 2018-04-06 23:53:44 -04:00
Anthony
9e2806c181 [AVIDump] fix compilation issues on Linux 2018-04-06 19:53:10 -07:00
Léo Lam
a957bd1ecc
Merge pull request #6421 from leoetlino/fs-interface 
IOS: Refactor the filesystem code
 2018-04-06 12:17:09 +02:00
Lioncash
3e946d87e4
DolphinWX/DolphinQt2 CMakeLists: Use cmake -E instead of mkdir -p for creating language directories 
CMake already has this functionality built-in. This lessens depending on the host system environment
and is more cross-platform friendly (which is always nice from a build-system point of view).
 2018-04-05 12:49:33 -04:00
Léo Lam
a3bdb5d85e
Merge pull request #6598 from lioncash/target 
DolphinQt2/CMakeLists: Use the target_* equivalents of add_definitions and include_directories
 2018-04-05 17:53:24 +02:00
Léo Lam
4cd5ef76ad
Merge pull request #6537 from spycrab/qt_quick_assign 
Qt/Mapping: Implement "Iterative Input"
 2018-04-05 17:44:30 +02:00
Lioncash
839fc7e749
DolphinQt2/MainWindow: Resolve a memory leak on systems with X11 
In the case we had X11 libs available, we'd allocate an XRRConfiguration instance and pass it
to the GraphicsWindow instance, but it would never actually be freed.
 2018-04-05 09:07:08 -04:00
Lioncash
9c27c7eda8
DolphinQt2/CMakeLists: Use the target_* equivalents of add_definitions and include_directories 
add_definitions and include_directories don't operate on a by-target basis, they act on a
by-directory basis (i.e. if we defined two targets, A and B, in this CMakeLists file, add_definitions
would add the definitions to the COMPILE_DEFINITIONS directory property which both A and B would
implicitly use).

The same idea applies to include_directories, only it appends to the INCLUDE_DIRECTORIES directory
property.

Instead, specify these on the target to keep scope as narrow as possible.
 2018-04-05 07:52:25 -04:00
Léo Lam
d0b7c013a1
Merge pull request #6593 from lioncash/headless 
DolphinNoGUI/CMakeLists: Remove the use of SRCS and LIBS variables
 2018-04-05 10:07:31 +02:00
Léo Lam
39cb22ddc9
Merge pull request #6594 from lioncash/qt 
DolphinQt2/CMakeLists: Specify Qt libraries via COMPONENTS in the find_package call
 2018-04-05 10:03:41 +02:00
Markus Wick
a9cd67125c
Merge pull request #6597 from lioncash/fp-load-store 
Interpreter_LoadStore: Generate alignment exceptions if an FP load/store instruction's effective address is not word aligned
 2018-04-05 09:55:49 +02:00
Lioncash
912c9490c0 Interpreter_LoadStore: Generate alignment exceptions if an FP load/store instruction's effective address is not word aligned 
This is one of the conditions for an alignment exception documented in
the 750CL architecture reference manual in section 4.5.6, which also
applies to the Gekko microprocessor.
 2018-04-05 00:30:53 -04:00
Lioncash
980f1641b5 Interpreter_LoadStore: Generate alignment exceptions if dcbz or dcbz_l are executed with the data cache disabled 
This is an exception condition documented within section 4.5.6 in the
architecture reference manual for the PPC 750CL, which also applies to
the Gekko microprocessor.

Also moves dcbz_l's implementation out of Interpreter_Paired and beside
dcbz where it belongs.
 2018-04-04 18:44:17 -04:00
spycrab
e0ba2a4aeb Qt: Implement "Iterative Input" 2018-04-04 21:51:51 +02:00
Lioncash
fb929ab8e5
DolphinQt2/CMakeLists: Specify Qt modules via COMPONENTS in the find_package call 
Eliminates the need to find the individual modules separately
 2018-04-04 15:05:20 -04:00
Lioncash
6f694e435c
DolphinNoGUI/CMakeLists: Remove the use of SRCS and LIBS variables 
Instead, operate on the target directly. This removes the last usages of the
SRCS and LIBS variables.
 2018-04-04 11:42:57 -04:00
Léo Lam
9be505fde2
Merge pull request #6473 from spycrab/qt_dbg_memory 
Qt/Debugger: Implement "Memory" widget
 2018-04-04 16:58:04 +02:00
Léo Lam
4d5adf3dfa
Merge pull request #6588 from lioncash/cmake 
DolphinWX/DolphinQt2 CMakeLists: Remove use of LIBS and SRCS variables
 2018-04-04 16:57:01 +02:00
Lioncash
5e4446c313
DolphinQt2/CMakeLists: Remove usages of LIBS and SRCS variables 
Instead, operate on the target itself. Also removes the variable
representing the name of the target. We can just refer to this directly
 2018-04-04 09:09:45 -04:00
spycrab
95ae4b34d9 Qt/Debugger: Implement "Memory" widget 2018-04-04 13:43:30 +02:00
Markus Wick
c6d0d9a01f
Merge pull request #6578 from JosJuice/remove-projection-hacks 
Remove support for projection hacks
 2018-04-04 09:10:32 +02:00
Markus Wick
ba42238b0b
Merge pull request #6592 from lioncash/imagine-le-ppc 
Interpreter_LoadStore: Generate alignment exceptions if lmw, lswi, lswx, stmw, stswi, or stswx is executed when the MSR[LE] bit is set
 2018-04-04 09:00:45 +02:00
Markus Wick
b82539e927
Merge pull request #6589 from lioncash/jni 
Android/CMakeLists: Remove usages of LIBS and SRCS variables
 2018-04-04 08:57:10 +02:00
Lioncash
3ea0a37d72 Interpreter_LoadStore: Generate alignment exceptions if lmw, lswi, lswx, stmw, stswi, or stswx is executed when the MSR[LE] bit is set 
Improves exception accuracy regarding an admittedly very unlikely
scenario.
 2018-04-03 20:47:40 -04:00
Lioncash
74aff4d9ef
HiresTexture: Correct texture hashes 
Fixes a regression introduced in 2da8d98b2f
 2018-04-03 12:42:05 -04:00
Lioncash
21ee216e63
Android/CMakeLists: Remove usages of LIBS and SRCS variables 
Instead, operate on the target itself.
 2018-04-03 08:05:43 -04:00
Lioncash
516b46845d
DolphinWX/CMakeLists: Remove usages of the LIBS and SRCS variables 
Instead, operated on the target itself.
 2018-04-03 08:04:29 -04:00
Markus Wick
1e0f72f2da
Merge pull request #6585 from lioncash/exception 
Interpreter_LoadStore: Handle alignment exceptions in lmw, lwarx, stmw, and stwcx + fixes for eciwx and ecowx
 2018-04-03 09:52:36 +02:00
Anthony
971a253a88
Merge pull request #6591 from JosJuice/fix-android 
Fix build error on Android
 2018-04-03 00:22:44 -07:00
JosJuice
3fe0051a53 Fix build error on Android 
Caused by 4387432.
 2018-04-03 08:32:55 +02:00
Léo Lam
91f3650fa5
Merge pull request #6586 from lioncash/video-backends 
CMakeLists: Migrate video backends off the add_dolphin_library macro and remove said macro
 2018-04-02 17:10:52 +02:00
Stenzek
9924434cdf
Merge pull request #6573 from stenzek/bad-shader-uid-cache 
ShaderCache: Improve shader UID cache file reliability
 2018-04-03 01:00:09 +10:00
Lioncash
de0ed1a5fb
Interpreter_LoadStore: Update the DAR if a DSI exception occurs in eciwx and ecowx 
Also once a DSI exception occurs, execution is supposed to leave the
instruction immediately. It doesn't finish execution.
 2018-04-02 08:34:32 -04:00
Lioncash
a013638dcb
Interpreter_LoadStore: Properly update the DAR whenever an alignment exception occurs within eciwx and ecowx 
These should be updating the DAR when an alignment exception occurs,
just like every other instruction that can cause an alignment exception.
 2018-04-02 08:34:32 -04:00
Lioncash
c1b78106e7
Interpreter_LoadStore: Flag alignment exceptions on misaligned addresses in lwarx, lmw, stmw, and stwcx 
The effective address given to these instructions must be word (4 byte) aligned,
and if the address is not aligned like that, then an alignment exception
gets triggered.

We currently don't update the DSISR in this case properly, since we
didn't really handle alignment exceptions outside of ecowx and eciwx,
and even then the handling of it isn't really that great, considering
the DAR isn't updated with the address that caused the exception to
occur.

The DSISR will eventually be amended to be properly updated.
 2018-04-02 08:34:26 -04:00
Lioncash
22be923b91
CMakeLists: Remove add_dolphin_library macro 
With all library targets migrated off add_dolphin_library, we can finally remove it
 2018-04-02 08:31:56 -04:00
Lioncash
b184923540
Vulkan/CMakeLists: Migrate off add_dolphin_library 
Finishes the migration work started in 3a4c3bbe01
 2018-04-02 08:29:37 -04:00
Lioncash
8b43a31855
Software/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:24:40 -04:00
Lioncash
a3c53ff754
OGL/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:22:39 -04:00
Lioncash
d4f8502ad1
Null/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:17:00 -04:00
Lioncash
3854e2bcca
D3D/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:15:22 -04:00
Markus Wick
2449be7f0c
Merge pull request #6571 from lioncash/rotate 
CommonFuncs: Generify rotation functions and move them to BitUtils.h
 2018-04-02 12:18:22 +02:00
Markus Wick
dea30e08bf
Merge pull request #6576 from lioncash/iconv 
CMakeLists: Remove iconv from the LIBS variable
 2018-04-02 11:07:19 +02:00
Léo Lam
80525cfd4e
Merge pull request #6584 from lioncash/async-init 
AsyncRequests: In-class initialize class members
 2018-04-02 10:37:07 +02:00
Lioncash
672665dec0 AsyncRequests: In-class initialize class members 
Prior to this change, it's possible for m_wake_me_up_again to be used
while it's in an uninitialized state from the exposed API.

e.g.

- Using SetEnable after construction would perform an uninitialized read.
- Using PushEvent would perform an uninitialized read by way of operator |=.

internally, an uninitialized read can happen if PullEventsInternal() is
executed before other functions.

Just to avoid the whole possibility of performing uninitialized reads,
we just give the class member a default value of false.
 2018-04-01 19:06:43 -04:00
Lioncash
fd9eab73fb CPUDetect: Make CPUVendor enum an enum class 
Avoids dumping the enum contents into the global namespace.
 2018-04-01 17:47:50 -04:00
Léo Lam
bf8ffe5bfb
Merge pull request #6582 from lioncash/const 
Jit64/JitRegCache: Make member functions const qualified where applicable
 2018-04-01 23:32:58 +02:00
Léo Lam
7d561c7e0e
Merge pull request #6579 from lioncash/socket 
IOS/Socket: Minor changes to WiiSocket
 2018-04-01 23:31:47 +02:00
Lioncash
0f6c3c7b35 Jit64/JitRegCache: Make member functions const qualified where applicable 
None of these member functions modify class state.

Also makes the parameter name for ScoreRegister's implementation
consistent with its declaration.
 2018-04-01 16:53:00 -04:00
JosJuice
c6931ee5b8
Merge pull request #6577 from lioncash/memcard 
EXI_DeviceMemoryCard: Get rid of magic number in SetCS()
 2018-04-01 22:08:36 +02:00
JosJuice
621e1758fb
Merge pull request #6581 from lioncash/const 
DSPJitRegCache: Make FindFreeReg() a const member function
 2018-04-01 22:05:48 +02:00
Lioncash
6cfa9fda6b DSPJitRegCache: Make FindFreeReg() a const member function 
This member function doesn't modify class state.
 2018-04-01 16:01:25 -04:00
Lioncash
fe9d989765 DSPJitRegCache: Remove unnecessary casts in FlushRegs() 
We can just use the proper printf specifiers instead.
 2018-04-01 15:49:21 -04:00
JosJuice
91732e2baf Remove support for projection hacks 
This isn't really useful for anything anymore as far as I know.
 2018-04-01 21:41:18 +02:00
Lioncash
ad17d9a979 IOS/Socket: Delete WiiSocket's copy constructor 
If the copy assignment operator is deleted, then the copy constructor
should be deleted as well, otherwise it's a hole in the API where copies
can be made (and if this were an intended case, it should be
documented).

So we delete the copy constructor and explicitly default the move
assignment and move constructor to signify this is intended to be a
move-only type.
 2018-04-01 15:38:37 -04:00
Lioncash
ad575a1556 IOS/Socket: Place WiiSocket's private interface below the public interface 
In the rest of the codebase we try to position the private interface
below the public interface (unless it's otherwise not possible).
 2018-04-01 15:38:33 -04:00
Lioncash
abb33637a3 IOS/Socket: In-class initialize WiiSocket members 2018-04-01 15:27:58 -04:00