dolphin/Source/Core/Common
JosJuice 5978550b2f Android: Fix in-game settings changes not getting saved
EmulationActivity has an instance of Settings. If you go to
SettingsActivity from EmulationActivity and change some settings,
the changes get saved to disk, but EmulationActivity's Settings
instance still contains the old settings in its map of all
settings (assuming the EmulationActivity was not killed by the
system to save memory). Then, once you're done playing your
game and exit EmulationActivity, EmulationActivity calls
Settings.saveSettings. This call to saveSettings first overwrites
the entire INI file with its map of all settings (which is
outdated) in order to save any legacy settings that have changed
(which they haven't, since the GUI doesn't let you change legacy
settings while a game is running). Then, it asks the new config
system to write the most up-to-date values available for non-legacy
settings, which should make all the settings be up-to-date again.
The problem here is that the new config system would skip writing
to disk if no settings changes had been made since the last time
we asked it to write to disk (i.e. since SettingsActivity exited).

NB: Calling Settings.loadSettings in EmulationActivity.onResume
is not a working solution. I assume this is because
SettingsActivity saves its settings in onStop and not onPause.
2021-01-18 15:27:16 +01:00
..
Config Android: Fix in-game settings changes not getting saved 2021-01-18 15:27:16 +01:00
Crypto Externals: Add zstd 2020-05-13 20:53:10 +02:00
Debug Common: Move OSThreads into core 2020-10-21 07:35:42 -04:00
GL Rehabilitate Haiku support. 2021-01-02 16:54:24 -05:00
Logging Split OSREPORT logging type 2020-12-24 23:38:59 -06:00
Align.h
Analytics.cpp Common/Analytics: Convert std::string overload into std::string_view 2019-06-05 13:24:31 -04:00
Analytics.h Common/Analytics: Replace mutex with shared_mutex and minor cleanups. 2020-01-25 14:04:00 -06:00
AndroidAnalytics.cpp Android: Add usage statistics to android. 2018-08-23 17:31:17 -04:00
AndroidAnalytics.h Android: Add usage statistics to android. 2018-08-23 17:31:17 -04:00
Arm64Emitter.cpp Arm64Emitter: Convert IndexType to enum class 2021-01-15 23:27:11 -08:00
Arm64Emitter.h Arm64Emitter: Convert IndexType to enum class 2021-01-15 23:27:11 -08:00
ArmCommon.h ArmCommon: Mark NO_COND as constexpr 2020-12-30 20:54:05 -05:00
ArmCPUDetect.cpp Add support for FreeBSD/arm64 2020-08-27 21:54:04 +01:00
Assert.h Common/Assert: no longer needs special impl for msvc 2020-08-23 13:57:05 -07:00
Atomic.h
Atomic_GCC.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
Atomic_Win32.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
BitField.h Externals: Add zstd 2020-05-13 20:53:10 +02:00
BitField.natvis
BitSet.h BitSet: Add << operator 2018-10-28 17:57:46 +00:00
BitUtils.h BitUtils: cleanup constexpr usage for msvc clz 2021-01-10 10:06:30 -08:00
BlockingLoop.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
CDUtils.cpp Remove obsolete "Windows compatibility" macros 2019-10-07 22:46:37 +02:00
CDUtils.h CDUtils: Amend function names 2018-05-27 18:48:09 -04:00
ChunkFile.h General: Convert PanicAlerts over to fmt equivalent 2020-12-02 13:38:33 -05:00
CMakeLists.txt Rehabilitate Haiku support. 2021-01-02 16:54:24 -05:00
CodeBlock.h x64Emitter: Check end of allocated space when emitting code. 2020-08-24 19:31:32 +02:00
ColorUtil.cpp ColorUtil: Amend function name casing 2018-05-27 21:04:48 -04:00
ColorUtil.h ColorUtil: Amend function name casing 2018-05-27 21:04:48 -04:00
Common.h Remove obsolete "Windows compatibility" macros 2019-10-07 22:46:37 +02:00
Common.vcxproj Common: Validate the number of {} fields in format strings 2020-11-19 17:09:24 +01:00
Common.vcxproj.filters Common: Validate the number of {} fields in format strings 2020-11-19 17:09:24 +01:00
CommonFuncs.cpp Add Android check for strerror_r variant 2020-07-16 18:51:58 +02:00
CommonFuncs.h Move GetModuleName to Common 2019-10-07 22:46:36 +02:00
CommonPaths.h Core: Add new Free Look settings and config 2020-12-24 13:49:25 -06:00
CommonTypes.h CommonTypes: Qualify standard integral types in typedefs with std:: 2017-08-20 19:34:52 -04:00
CompatPatches.cpp handle to GetFileVersionInfoW must be zero 2020-08-23 13:55:14 -07:00
CPUDetect.h CPUDetect: Indicate slow PDEP/PEXT only for Zen1/+/2 (Family 23) 2020-11-08 14:27:24 +01:00
DebugInterface.h Debugger: Add a Thread widget 2020-05-03 20:48:30 +04:00
DynamicLibrary.cpp Common: Use fmt where applicable 2019-06-14 15:04:09 -04:00
DynamicLibrary.h Common: Add DynamicLibrary helper class 2019-03-29 19:52:33 +10:00
ENetUtil.cpp Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
ENetUtil.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
Event.h Minor changes to usages of std::condition_variable. 2019-04-06 17:39:25 -05:00
File.cpp Android: Make the handling of SAF open modes more robust 2020-11-06 17:40:03 +01:00
File.h IOFile: Add WriteString() method to replace fprintf string writing. 2020-11-25 15:41:25 +01:00
FileSearch.cpp Android: Add specialized content provider implementation of DoFileSearch 2020-12-28 21:00:10 +01:00
FileSearch.h replace DoFileSearch with optimized version 2017-06-23 17:25:53 -07:00
FileUtil.cpp Merge pull request #9318 from JosJuice/android-saf-games 2020-12-30 11:10:35 +01:00
FileUtil.h Merge pull request #9318 from JosJuice/android-saf-games 2020-12-30 11:10:35 +01:00
FixedSizeQueue.h FixedSizeQueue: Work around GCC generating large amounts of debug info 2019-10-06 16:23:45 +10:00
Flag.h Reformat all the things! 2018-04-12 21:28:39 +02:00
FloatUtils.cpp FloatUtils: Clean up memcpy usages 2018-05-10 12:28:09 -04:00
FloatUtils.h Attempt to fix linter issues. 2018-08-13 12:17:56 -07:00
FormatUtil.h Common: Assert that translatable strings use positional arguments 2020-11-20 20:24:30 +01:00
FPURoundMode.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
GekkoDisassembler.cpp GekkoDisassembler: fix rld* 2020-08-23 13:55:14 -07:00
GekkoDisassembler.h Common/GekkoDisassembler: Don't print out '\0' as a character 2019-07-03 20:12:50 -04:00
GenericCPUDetect.cpp
GenericFPURoundMode.cpp Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
Hash.cpp Fix -Wsign-compare warnings 2020-11-21 02:08:09 +01:00
Hash.h Use size_t in some DSP code code 2020-07-24 15:06:39 -07:00
HttpRequest.cpp Common: Fix logger related crash when HTTP response is empty 2020-10-29 21:20:59 +01:00
HttpRequest.h Common/HttpRequest: Add option to allow non 200 response codes 2019-04-13 12:58:23 +02:00
Image.cpp Merge pull request #9332 from leoetlino/warning-fixes 2020-12-19 21:45:21 -05:00
Image.h Core: Remove ImageWrite and get rid of -Wmissing-declarations warnings 2020-12-16 16:04:19 +01:00
IniFile.cpp Common/IniFile: Add Exists function for section name only 2020-02-29 01:39:36 -05:00
IniFile.h Common/IniFile: Add Exists function for section name only 2020-02-29 01:39:36 -05:00
Inline.h Externals: Add zstd 2020-05-13 20:53:10 +02:00
Intrinsics.h Reformat all the things! 2018-04-12 21:28:39 +02:00
JitRegister.cpp Common: Use fmt where applicable 2019-06-14 15:04:09 -04:00
JitRegister.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
Lazy.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
LdrWatcher.cpp [windows]: Apply compatibility patches to problematic gamepad vibration drivers. 2017-06-15 21:21:01 -07:00
LdrWatcher.h [windows]: Apply compatibility patches to problematic gamepad vibration drivers. 2017-06-15 21:21:01 -07:00
LinearDiskCache.h Common/LinearDiskCache: Handle truncated shadercache files. 2020-12-19 19:09:33 +01:00
make_scmrev.h.js make_scmrev.h.js: set default auto-update track from environment 2018-03-19 00:11:55 +01:00
MathUtil.cpp Common: Move Matrix classes out of MathUtil into their own files and make their interface more friendly. 2019-02-03 11:35:31 -06:00
MathUtil.h BitUtils: Add CountLeadingZeros 2020-12-27 22:56:43 +00:00
Matrix.cpp Common/Matrix: Add Quaternion class. 2020-10-19 16:18:31 -05:00
Matrix.h Common/Matrix: Allow TVec classes to be used in constexpr contexts 2020-10-21 17:44:02 -04:00
MD5.cpp Common: Use fmt where applicable 2019-06-14 15:04:09 -04:00
MD5.h
MemArena.cpp General: Convert PanicAlerts over to fmt equivalent 2020-12-02 13:38:33 -05:00
MemArena.h Common: Add MemArena.h/cpp to the Common namespace 2018-05-15 18:27:32 -04:00
MemoryUtil.cpp MemoryUtil: Use HW_PHYSMEM64 sysctl in MemPhysical 2020-12-20 22:25:36 +00:00
MemoryUtil.h remove MemUsage, and therefor psapi dependency 2017-06-08 22:25:46 -07:00
MinizipUtil.h Externals: Update minizip search path. 2020-04-29 12:41:36 +02:00
MsgHandler.cpp Common/MsgHandler: Add fmt-capable variants of the alert macros 2020-11-09 08:48:17 -05:00
MsgHandler.h Common: Assert that translatable strings use positional arguments 2020-11-20 20:24:30 +01:00
NandPaths.cpp Common: Use fmt where applicable 2019-06-14 15:04:09 -04:00
NandPaths.h NetPlay: Synchronize Mii data 2019-04-08 07:06:21 -04:00
Network.cpp Common/Network: Use std::nullopt in StringToMacAddress 2019-12-06 09:59:11 -05:00
Network.h Common/Network: Make StringToMacAddress use a string_view 2019-12-06 09:45:25 -05:00
PcapFile.cpp PcapFile: Namespace code under the Common namespace 2018-05-29 17:56:15 -04:00
PcapFile.h PcapFile: Namespace code under the Common namespace 2018-05-29 17:56:15 -04:00
PerformanceCounter.cpp
PerformanceCounter.h
Profiler.cpp Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
Profiler.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
QoSSession.cpp Add Quality of Service (QoS) support 2018-03-09 00:11:18 +01:00
QoSSession.h Reformat all the things! 2018-04-12 21:28:39 +02:00
Random.cpp Common: Add Random utilities 2018-05-31 17:54:43 +02:00
Random.h Common/Random: Add convenience template for simple arithmetic values 2018-06-14 10:31:13 -04:00
Result.h Reformat all the things! 2018-04-12 21:28:39 +02:00
scmrev.h.in ConfigManager: Enable Auto-Updater by default 2018-04-26 15:12:15 +02:00
SCMRevGen.vcxproj Add an ARM64 target to Visual Studio projects 2019-12-28 19:20:41 +10:00
ScopeGuard.h Common: Avoid std::function overhead in ScopeGuard 2020-02-15 21:33:31 +01:00
SDCardUtil.cpp Common: Migrate logging to fmt 2020-10-23 14:58:03 -04:00
SDCardUtil.h SDCardUtil: Namespace SDCardUtil 2018-05-11 09:19:30 -04:00
Semaphore.h remove extraneous WIN32_LEAN_AND_MEAN definition 2020-08-23 13:57:05 -07:00
SettingsHandler.cpp SettingsHandler: Don't output null bytes 2020-03-24 17:01:15 +01:00
SettingsHandler.h SettingsHandler: Don't output null bytes 2020-03-24 17:01:15 +01:00
SFMLHelper.cpp Improve SFMLHelper 2018-10-02 05:44:50 -04:00
SFMLHelper.h Improve SFMLHelper 2018-10-02 05:44:50 -04:00
SPSCQueue.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
StringUtil.cpp Add NetBSD support 2020-12-15 02:34:25 +01:00
StringUtil.h DolphinQt: Handle non-ASCII characters in Windows cmd arguments 2020-09-21 17:26:29 +02:00
Swap.h Common/Swap: Amend BigEndianValue's operator= to return a reference to the object rather than returning void 2018-04-08 01:22:18 -04:00
SymbolDB.cpp Common: Migrate logging to fmt 2020-10-23 14:58:03 -04:00
SymbolDB.h Common/SymbolDB: Use std::string_view where applicable 2019-06-16 01:10:02 -04:00
Thread.cpp Add NetBSD support 2020-12-15 02:34:25 +01:00
Thread.h
Timer.cpp windows: fix some incorrect string lengths 2020-08-23 13:55:15 -07:00
Timer.h Merge pull request #8922 from Filoppi/timer-fixes 2020-07-13 00:16:45 +01:00
TraversalClient.cpp General: Convert PanicAlerts over to fmt equivalent 2020-12-02 13:38:33 -05:00
TraversalClient.h TraversalClient: Use u32 instead of enet_uint32 2018-04-16 16:46:48 -04:00
TraversalProto.h
TraversalServer.cpp TraversalServer: use C++ <chrono> instead of gettimeofday 2019-05-10 21:33:26 +02:00
UPnP.cpp Common: Migrate logging to fmt 2020-10-23 14:58:03 -04:00
UPnP.h Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
VariantUtil.h Common: Add missing header guards 2019-06-17 18:37:56 -04:00
Version.cpp Common: Move version strings to their own header 2017-09-09 19:28:10 -04:00
Version.h Common: Move version strings to their own header 2017-09-09 19:28:10 -04:00
WindowSystemInfo.h Rehabilitate Haiku support. 2021-01-02 16:54:24 -05:00
WorkQueueThread.h Extended WorkQueueThread class with Clear(), Cancel() and IsCancelled(). 2020-10-01 22:09:45 +02:00
x64ABI.cpp
x64ABI.h
x64CPUDetect.cpp CPUDetect: Indicate slow PDEP/PEXT only for Zen1/+/2 (Family 23) 2020-11-08 14:27:24 +01:00
x64Emitter.cpp General: Convert PanicAlerts over to fmt equivalent 2020-12-02 13:38:33 -05:00
x64Emitter.h DSP: Eliminate most global state 2020-12-27 06:38:02 -05:00
x64FPURoundMode.cpp Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
x64Reg.h