archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
19095 commits 5 branches 0 tags 1.9 GiB
Commit graph

60 commits

Author SHA1 Message Date
Tobias Koppers
f45a15b621
move custom allocator flag and add rustls-tls comment (#60128) 
### What?

enable the custom allocator flag to enable mialloc.
allow to configure custom allocator on napi level.

### Why?

It's faster and we had it enabled before.
It was disable before as `next-core` is used with no default features in
workspace

Native Build: https://github.com/vercel/next.js/actions/runs/7388725004


Closes PACK-2185

---------

Co-authored-by: OJ Kwon <1210596+kwonoj@users.noreply.github.com>
 2024-01-11 09:07:56 +01:00
Sam Ko
2d9c01099c
chore: update turbo to the latest (#60294) 
Update :turbo-new: to the latest (v.1.11.3).

Closes NEXT-2004
 2024-01-08 11:17:04 -08:00
JJ Kasper
05f2c68b7a
Increase default timeout for swc build (#59035) 
x-ref:
https://github.com/vercel/next.js/actions/runs/7022943529/attempts/3
 2023-11-28 12:15:35 -08:00
Leah
8bdda745fb
chore(CI): improve datadog reporting (#58267) 2023-11-23 15:18:03 +01:00
JJ Kasper
dc59d3cca9
Update CLI version for deploy examples job (#58318) 
Fixes:
https://github.com/vercel/next.js/actions/runs/6830557044/job/18578715963
 2023-11-13 11:36:51 -08:00
OJ Kwon
6f8c580386
feat(turbopack): Experimental wasm build (#57906) 
### What?

continuation of https://github.com/vercel/next.js/pull/57851, since it is from a remote branch that I don't have access to write.

Co-authored-by: Maia Teegarden <2865858+padmaia@users.noreply.github.com>
Co-authored-by: Tim Neutkens <6324199+timneutkens@users.noreply.github.com>
 2023-11-02 21:00:54 +00:00
Zack Tanner
811e5c4fd5
move release undraft step until after canary is fully published (#57324) 
Currently we publish a release in GitHub before it's actually fully published to npm. This moves the undraft step until after the publish is finished
 2023-10-31 18:37:06 +00:00
Maia Teegarden
f412c8a991
Remove wasm target (#57437) 
This PR removes the wasm target for the next-swc build for the next major version.  The main motivation is that Turbopack does not support targeting wasm yet, and it would be a significant amount of work to add. We plan to make Turbopack the default zero-config experience in a minor version, possibly before we are able to support a wasm target, so we need to make this breaking change now. We also plan to make more improvements to the webpack experience with shared Rust code, which we have so far been blocked from implementing because of the current wasm restrictions. We would like to support a wasm target again in the future, but cannot say at this time when that would be.


Closes WEB-1865
 2023-10-26 02:29:07 +00:00
JJ Kasper
02fad82933
Revert "Increase build-native CI job timeout (#57314)" (#57325) 
This reverts commit 003ec7a15b.

Re-adding this as a safe guard as the stalling was a real issue
 2023-10-24 06:19:28 +00:00
JJ Kasper
003ec7a15b
Increase build-native CI job timeout (#57314) 
This is currently timing out so this increases the timeout for Windows
specifically
 2023-10-23 20:52:39 -07:00
Balázs Orbán
1ff7f07875
feat: drop Node.js 16 (#56896) 
### What?

BREAKING CHANGE: Bump the minimum required Node.js version.

### Why?

Node.js 16 has reached end-of-life in September.

Bumped to `18.18.2` since it contained some security-related patches: https://nodejs.org/en/blog/vulnerability/october-2023-security-releases

### How?

Bumped `engines` where needed, upgraded the workflows.

This will allow us to remove quite a few polyfills, I'll open separate PRs for those.
 2023-10-16 21:41:38 +00:00
JJ Kasper
0a6c60cec6
Break out E2E deploy test workflow to its own (#56755) 
As discussed with @feedthejim this breaks our E2E deploy tests workflow into it's own so it can be triggered on cron/manually easier. 

One thing we'll need to consider with the cron/manual workflow is if a canary isn't published yet and Next.js relies on swc changes it will fail since this doesn't pack/publish a fresh built swc binary currently.
 2023-10-12 16:34:27 +00:00
Jimmy Lai
ebebb6a96a
CI: add manual workflow for running e2e on prod (#56738) 
This PR adds a job to the `build-and-deploy` workflow so that we run e2e
tests on production/vercel if the job was dispatched manually.

This is useful if you need to double-check your PR since we don't run
them on production for every PRs.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
 2023-10-12 10:55:52 +02:00
Sukka
edb92a30b5
test: speed up isolated next instance test setup (#56525) 2023-10-07 00:15:59 +02:00
LongYinan
d665c3df4d
Upgrade to latest NAPI-RS infra (#55505) 
Should also resolve the msvc runtime issue: https://nextjs.org/docs/messages/failed-loading-swc#possible-ways-to-fix-it
 2023-09-20 23:37:28 +00:00
OJ Kwon
f393f55678
fix(next-core): enable image extensions (#55460) 
### What?

Enables the image extensions supported by turbopack.

Also fixes test fixture to assert error overlay header.


Closes WEB-1587
 2023-09-18 17:30:27 +00:00
Jiachi Liu
94ae5098bd
Test with latest node@18 (#54000) 
Basically revert #52894, should be able to keep testing against latest node 18
 2023-09-12 21:47:51 +00:00
JJ Kasper
952c536a3b
Consider cargo config in granular cache key (#54700) 
x-ref: [slack
thread](https://vercel.slack.com/archives/C04KC8A53T7/p1693270746110069)
 2023-08-28 22:29:28 -07:00
JJ Kasper
8997ab0812
Implement granular rust caching (#54582) 
This fixes our caching for the docker builds as they were missing inputs
the other jobs had also enables caching the rust target cache which
improves build times when only changing our package and the lockfile
isn't invalidated.

Tested here https://github.com/vercel/next.js/actions/runs/5987764387
 2023-08-26 18:54:14 -07:00
JJ Kasper
8afd85d47f
Add missing install env for release stats (#54581) 
This should fix the stalled action as it seems we aren't skipping this postinstall step when we should be which explains why it was passing for PR stats but not release stats

x-ref: https://github.com/vercel/next.js/actions/runs/5980582756/job/16227150469
 2023-08-25 22:44:15 +00:00
JJ Kasper
eee137615e
Update release stats install/build executing (#54576) 
Aims to make debugging the release stats failure easier as currently we
don't see the logs are the command is executing

x-ref:
https://github.com/vercel/next.js/actions/runs/5976635577/job/16221230094
x-ref: https://github.com/vercel/next.js/pull/54536
 2023-08-25 12:45:58 -07:00
JJ Kasper
2590f4931b
Update runner labels for PR stats (#54524) 
Speeds up our stats generation by swapping out the underlying runner,
previously this took 13+ minutes now it's around 5 minutes.
 2023-08-24 13:47:09 -07:00
JJ Kasper
e471a46a28
Enable verbose logging for turbo in CI (#54525) 
Gives us more insight into turbo runs when building swc
 2023-08-24 12:49:17 -07:00
OJ Kwon
61e1858241
chore(ci): small notes for the build steps (#54073) 
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

### What?

Leaving a small note to the build steps to avoid regressions like
https://github.com/vercel/next.js/issues/54017 later.


Closes WEB-1386

---------

Co-authored-by: Steven <steven@ceriously.com>
 2023-08-15 15:26:25 -07:00
JJ Kasper
bdc3a8e181
Move turbo outside of build for docker swc builds (#54035) 
removes usage of turbo and uses the default node version inside the
image.
 2023-08-14 17:37:45 -07:00
OJ Kwon
380c17f75f
ci(next-swc): print glibc version when build (#54026) 
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

### What?

PR dumps out next-swc's glibc linkage after build completes, for easier
bisect if regression occurs.
 2023-08-14 16:03:41 -07:00
JJ Kasper
3d245facea
Leverage previous swc build images (#54027) 
This rolls back our build image for our swc builds as it seems to cause a GLIBC version conflict. 

x-ref: [slack thread](https://vercel.slack.com/archives/C04KC8A53T7/p1692049361819349?thread_ts=1692039503.188119&cid=C04KC8A53T7)
 2023-08-14 21:57:44 +00:00
JJ Kasper
a7c5d8a44a
Remove extra label from runner (#54002) 
All have docker available now so don't need this label to distinguish anymore.
 2023-08-14 17:00:52 +00:00
JJ Kasper
6b6f0a2dd1
Update turbo env handling (#53970) 
This ensures env variables are passed through as expected when building
the next-swc binaries, also removes an extra GH actions that isn't
really needed as it's just a wrapper around `docker run`.

Validated changes against run here
https://github.com/vercel/next.js/actions/runs/5851719808/job/15862899331
 2023-08-13 21:39:15 -07:00
JJ Kasper
9a6ae144a9
Update swc runners config (#53939) 
This fixes unexpected cache hits occurring causing latest next-swc
changes to not be built for the docker based builds. Noticed in our
turbo run summaries for these builds that no input files were detected
most likely due to older Node.js/pnpm versions being used from the old
Docker image.

This also updates to leverage new runner labels for better build perf
cutting build times down from over an hour down to around 20 min.

Fixes build issue on aarch64-linux-musl due to `TurboMalloc` not being
able to resolve. Test build done here
https://github.com/vercel/next.js/actions/runs/5850893681/job/15860929304

x-ref:
https://github.com/vercel/next.js/actions/runs/5843580924/job/15845848384

x-ref:
https://github.com/vercel/next.js/actions/runs/5837652747/job/15833506858
x-ref:
https://github.com/vercel/next.js/actions/runs/5837652747/job/15833506925
x-ref:
https://github.com/vercel/next.js/actions/runs/5837652747/job/15833507067
x-ref:
https://github.com/vercel/next.js/actions/runs/5837652747/job/15833507135
 2023-08-13 19:02:48 -07:00
Dima Voytenko
4c14482553
[chore] Upgrade playwright to 1.35.1 (#53875) 2023-08-11 23:25:01 +00:00
Leah
ddc8f50d24
enable @vercel/og support for turbopack (#53917) 
### What?

Now that we have wasm support (and support for `?module`) `@vercel/og` should be supported

### Turbopack updates

* https://github.com/vercel/turbo/pull/5677 
* https://github.com/vercel/turbo/pull/5660 

Closes WEB-138
 2023-08-11 22:16:41 +00:00
OJ Kwon
e127c51327
test(turbo): allow to run test with --experimental-turbo (#53396) 
### What?

Allows to configure test runs with --experimental turbo.
 2023-08-09 05:48:54 +00:00
Leah
542c4fc26a
chore: update to pnpm@8.6.11 (#50923) 
https://github.com/pnpm/pnpm/releases/tag/v8.0.0
 2023-08-04 19:40:20 +00:00
JJ Kasper
728fd7572a
Update to latest version of turborepo (#52979) 
x-ref: [slack
thread](https://vercel.slack.com/archives/C03LMQZL205/p1689895062566699?thread_ts=1688753294.342269&cid=C03LMQZL205)
 2023-07-21 10:04:06 +02:00
Jiachi Liu
31453fa20e
Lock node version to 18.16 (#52894) 
As we're using nodejs with latest version of 18.x on CI, there's a new behavior change of `url.fileURLToPath` that didn't join the paths as expected

locally with node 16.x or 18.16
```
/private/var/folders/mh/y8kwzkls6v3_w3_k6q384cw80000gn/T/next-install-b033b516612809c6fb0a0de77c6e50f7d7f8af34dfd3d01812b99345352dc992/node_modules/.pnpm/file+..+next-repo-7e52b07043e986127273a2d951e5c412b0dd45fb24eb34001bd372e2afff79db+packages+n_vyqu6i4c4i3efp5pqsaeaoe5s4/node_modules/next/dist/compiled/@vercel/og/noto-sans-v27-latin-regular.ttf
```

in the actions runner with node 18.17 it's
```
/tmp/next-install-8efaa47c1546bed07990d8f130decceb6536e1a36146e7885cb68e3c3dea21f7/node_modules/.pnpm/file+..+next-repo-9679355e05341947e7aa0b42c994e3ac_krcuriy4thl7zawouf7sswlrgy/node_modules/next/dist/compiled/@vercel/og/index.node.js/../noto-sans-v27-latin-regular.ttf
```

You can see that `index.node.js` is still present in the path as a folder which is unexpected
```
index.node.js/../
```

x-ref: https://github.com/vercel/next.js/actions/runs/5600417148/jobs/10242827739?pr=52790
 2023-07-19 16:15:58 +00:00
OJ Kwon
e1baffcec2
feat(turbopack): support native webp (#52285) 
### What?

Closes WEB-1157. PR enables turbopack to support native webp encode / decode. There is one platform we can't support this (aarch64-linux-gnu) which disables those.
 2023-07-12 19:42:41 +00:00
JJ Kasper
1033a03d86
Update needs for build and deploy (#51731) 
These don't need to wait for the build step so we can remove the "needs"
step from them to allow them to start earlier.
 2023-06-23 17:14:22 -07:00
Alex Kirszenberg
c6313606c9
Next Build Turbo POC (2) (#51546) 
Another attempt at getting https://github.com/vercel/next.js/pull/49942 in.

This time, the mold install step is gated to Linux.
 2023-06-22 08:03:44 +00:00
JJ Kasper
056ab7918f
Revert "Fix pnpm ERR_INVALID_THIS on Node 20" (#51539) 
Reverts vercel/next.js#51406

This pnpm bump seems to be causing lockfile issues with the react
versions which causes context issues since we need to share the same
react version in the monorepo.
 2023-06-19 23:38:15 -07:00
Nick McCurdy
1602c2af25
Fix pnpm ERR_INVALID_THIS on Node 20 (#51406) 
### What?

Fixes pnpm/pnpm#6424

### Why?

So users of Node 20 can contribute to Next.js

### How?

Upgrades pnpm with back compatibility to patch `ERR_INVALID_THIS` error.
If Node 14 support isn't necessary, I'd recommend upgrading to pnpm 8
for continued feature support and committing the lockfile.

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
 2023-06-16 05:37:11 -07:00
OJ Kwon
d6952989a8
ci(workflow): upload test trace for deploy e2e (#51389) 
### What?

WEB-1193.

context: https://vercel.slack.com/archives/C04DUD7EB1B/p1686873054726149

we want to observe flakyness over deploy e2e tests.
 2023-06-16 12:14:43 +00:00
JJ Kasper
bdcca0ccff
Fix CSS deploy id case (#51325) 
x-ref: [slack
thread](https://vercel.slack.com/archives/C04MEB9L9RQ/p1686787663510239?thread_ts=1686770561.895939&cid=C04MEB9L9RQ)
 2023-06-14 20:28:18 -07:00
JJ Kasper
b4350466c7
Update e2e deploy tests to continue (#51321) 
Instead of temporarily disabling flakey or unpatched tests in deploy
mode this continues to run all tests and see all failures at once.

x-ref:
https://github.com/vercel/next.js/actions/runs/5272454654/jobs/9536161644
 2023-06-14 17:00:28 -07:00
JJ Kasper
323e335b54
Ensure swc is copied for release stats (#51315) 
x-ref:
https://github.com/vercel/next.js/actions/runs/5266469399/jobs/9520655185
 2023-06-14 14:48:20 -07:00
JJ Kasper
6dcc4fbc23
Increase remote cache timeout for swc builds (#51270) 
These occasionally timeout and start building even when they don't need
to so this increases them a bit from the default.
 2023-06-13 21:31:40 -07:00
OJ Kwon
6ba6762d75
ci(workflow): consolidate bytesize upload workflow (#51110) 
### What?

context: https://github.com/vercel/next.js/actions/runs/5231928600/jobs/9446394605#step:16:33

For some reason, installing datadog cli on some action runner (Windows) is unexpectedly slow: while other platform takes ~30s, windows only takes more than > 7m.

PR updates workflow logic to consolidate artifacts, and then send metrics at once on a separate ubuntu workflow.
 2023-06-11 04:42:22 +00:00
OJ Kwon
9bc73dbc1a
ci(workflow): generate run summary for all build targets (#51057) 
### What?

I noticed some deploy job fails at

https://github.com/vercel/next.js/actions/runs/5222848985/jobs/9428961695#step:15:20

when there's no summary exists by missing necessary flags for the few platform targets.
 2023-06-10 00:27:44 +00:00
Steven
f1f5734e91
chore: pin to npm@9.6.7 (#51044) 
This might fix the npm publish error

```
Error: Command failed with exit code 254 (Unknown system error -254): npm publish /home/runner/work/next.js/next.js/packages/next --access public --tag canary
```


https://github.com/vercel/next.js/actions/runs/5219901558/jobs/9422546478#step:11:9353
 2023-06-09 07:58:32 -07:00
JJ Kasper
9a3e76377a
Fix windows build check 2023-06-08 07:38:38 -07:00