Commit graph

7633 commits

Author SHA1 Message Date
Damien Varron
55afe80c31
Only prefetch Link if router is in context (#19857)
Fixes #16864 

The `router` can be missing in a test environment when trying to render a `Link` component. This PR bails out of `router.prefetch()` when `router` is missing.

The alternative is for users to mock `next/link` or to mock the `router` and wrap their test components.

Please let me know any feedback.
2021-01-06 16:19:57 +00:00
Michael Aufreiter
ccf26a850d
Guard useSwr() to avoid sending invalid request (#20671) 2021-01-06 10:59:18 -05:00
Tim Neutkens
fb9ca49401
Update static file serving doc to mention Next.js 10 (#20815)
Fixes #20403
2021-01-06 15:21:34 +00:00
JJ Kasper
991ad9225a
Update error for mis-matching path in getStaticPaths (#20767)
This updates the error shown when a path doesn't match the dynamic route in `getStaticPaths` to not include the `locale` since this isn't considered when matching against the dynamic route.
2021-01-06 10:27:32 +00:00
JJ Kasper
b9ba264bd6
Ensure i18n + API rewrite is handled correctly (#20751)
This ensures rewrites to API routes with i18n enabled handles as an API route correctly. This also adds tests for API routes in the i18n test suite

Fixes: https://github.com/vercel/next.js/issues/20725
2021-01-06 09:54:45 +00:00
Benjamin Bender
1a3adaa5d9
Fix mini typo in with-cookie-auth-fauna-example (#20808)
Fix mini typo
2021-01-06 09:13:45 +00:00
Lee Robinson
9afc0f58c4
Add docs for custom image loaders. (#20788)
Docs for https://github.com/vercel/next.js/pull/20216/.
2021-01-06 02:16:09 +00:00
Joe Haddad
9f6bcd47b6
v10.0.5-canary.10 2021-01-05 20:20:36 -05:00
JJ Kasper
47b7660aec
Ensure path starts with / when deleting index basePath with query (#20766)
This is a follow-up to https://github.com/vercel/next.js/pull/20596 and https://github.com/vercel/next.js/pull/20658 ensuring the `as` value is prefixed with the `basePath` correctly with a query. This updates the test to also ensure no errors are shown when a query is present on the index `basePath` route. 

Fixes: https://github.com/vercel/next.js/pull/20757#issuecomment-754338510
2021-01-06 01:20:04 +00:00
Josh
51f2a530d6
Updated deploy button URL (#20756)
* Updated deploy button URL

* Update bottom button
2021-01-05 17:36:33 -05:00
Thomas Wang
356bcdec03
Move window check to after initializing Firebase (#20764)
You can initialize the Firebase app instance without checking for window, but it is required for using the analytics module.
2021-01-05 21:59:37 +00:00
Alex Castle
c8bc17f330
Support for custom image loaders via image component prop (#20216)
This is a #19325 reconfigured to support a loader passed in via a `loader` prop on the Image component, rather than using a config-based approach.

The idea is that applications wanting to use a custom loader will create a wrapper element for the  image component that incorporates that loader. See a simple example of this pattern in the integration tests. 

This solution is similar to the one prototyped by @ricokahler in #20213 and described at https://github.com/vercel/next.js/issues/18606#issuecomment-720149156

---

Closes #19325
Fixes #18606
2021-01-05 20:51:34 +00:00
kaykdm
b6c6770cd9
Fix with-react-intl example (#20763)
Co-authored-by: Kanta Kodama <kanta.kodama@linecorp.com>
2021-01-05 11:44:40 -05:00
Tom
6fd877ff34
fix deploy button + create-next-app command (#20777) 2021-01-05 11:43:27 -05:00
Tom
266a4d33b1
fix deploy button (#20774) 2021-01-05 11:42:23 -05:00
tarunama
575fcf3fcf
refactor(client): add return types (#20728)
## summary
- Explicitly define return types
- Add type of  [Observer](https://github.com/vercel/next.js/pull/20728/files#diff-5de64b97b2f26e4e41d197a8295e8750825c75b8ca557a4b947a4c3569345974R7)
2021-01-05 15:11:37 +00:00
JJ Kasper
f8e44b9425
Add documentation for rewrite params query passing behavior (#20757)
Closes: https://github.com/vercel/next.js/issues/20197
2021-01-05 14:47:08 +00:00
Tuan Nguyen
873bf5dd76
Remove an undefined parameter (#20762)
`getLoginSession` takes only one argument
2021-01-05 14:26:06 +00:00
Tim Neutkens
a1a4af2d32 Bring back indicator documentation with a note that the feature has been removed 2021-01-05 12:47:52 +01:00
JJ Kasper
73a2bd6a4b
Add pr section to azure config (#20758)
Adds the `pr` section from https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#pr-triggers to filter paths that don't require test runs on PRs.
2021-01-05 01:41:42 +00:00
Jan Varho
b944b06f30
Fix notFound false pages returning 404 (#19861)
Currently pages with `notFound: false` from `getServerSideProps` behave the same as `notFound: true`, i.e. just having the key is enough to result in a 404. This fixes the check in render.tsx and adds tests for it.
2021-01-04 22:43:53 +00:00
Lee Robinson
5678d24f56
Add new example for rate limiting API routes. (#19509)
Adds an example using `lru-cache` to implement a simple rate limiter for API routes ([Serverless Functions](https://vercel.com/docs/serverless-functions/introduction)).

**Demo: https://nextjs-rate-limit.vercel.app/**
2021-01-04 22:19:31 +00:00
Jesse Jafa
0d98f370aa
Clarify ctx.query type on getServerSideProps (#20327)
Closes https://github.com/vercel/next.js/issues/19481

The current text implies `query` is a string. IMO it would be better if it clarified that `query` is an object containing the query string's keys and values

Edit:
Relevant docs url: https://nextjs.org/docs/basic-features/data-fetching#getserversideprops-server-side-rendering
2021-01-04 21:58:56 +00:00
zoomdong
87c97fd3e7
Update with-antd example (#19699)
https://ant.design/docs/react/getting-started#Import-on-Demand
At the document, We don't need to use `babel-import-plugin` to `Import on Demand`.
2021-01-04 21:34:28 +00:00
Manaia Junior
2e8259ffdc
Update withUser to useUser in README.md of the example with-iron-session (#20723) 2021-01-04 21:13:32 +00:00
Justin Philpott
2a4887c30a
New example: /with-storybook-styled-jsx-scss (#18570)
Hi, 

I'm submitting this PR for consideration as a new example app showing Styled JSX with SCSS working inside and outside storybook with example components.

Only known issue: I noticed that when running this example with:

`$ yarn next ./examples/with-storybook-styled-jsx-scss`

I receive the following error:

```
error - ./pages/_app.js
Error: [BABEL] .../next.js/examples/with-storybook-styled-jsx-scss/pages/_app.js: Cannot find module 'styled-jsx-plugin-sass' (While processing: ".../next.js/node_modules/next/babel.js")
```

However I notice that this same missing module error is triggered when running this existing example app "with-styled-jsx-scss".

Any changes/tweaks needed?

Thanks!
2021-01-04 20:46:34 +00:00
mongolyy
7f23954f7e
Update database config explanation in with-firebase-app example (#20709)
I made the following changes.

- Addition of procedure for setting private_key
- Addition of procedure for creating a database and setting database_url
2021-01-04 20:25:57 +00:00
Joe Haddad
cb50b040ea
fix(next/head): assign bool attrs to match server (#20748)
This pull request correctly assigns boolean attributes for `<script />` to match the element as it is created by a server-side render.

Prior to this pull request, we'd double-execute `<script>` tags with the `async`, `defer`, or `nomodule` property.

---

Fixes #9070
2021-01-04 19:57:52 +00:00
matamatanot
fc75baeb3c
Move sizes var declaration just before used (#18402)
As with `const width`, it should be declared just before it is used.
2021-01-04 18:09:07 +00:00
Kristoffer K
104b8d4732
fix(next-mdx): resolve webpack loader (#17983)
**What's the problem this PR addresses?**

`@next/mdx` adds the webpack loader `@mdx-js/loader` without resolving it to an absolute path

Depends on https://github.com/vercel/next.js/pull/17606

**How did you fix it?**

`require.resolve` the webpack loader before adding it
2021-01-04 16:24:16 +00:00
Joe Haddad
246c265fca
v10.0.5-canary.9 2021-01-04 10:31:56 -05:00
Kristoffer K
e848a9e504
fix(next): add missing peer dependencies for sass support (#17606) 2021-01-04 10:30:46 -05:00
Tim Neutkens
ad1150d2d1 Run prettier against new issue templates 2021-01-04 13:53:26 +01:00
Tim Neutkens
66be9c7a0e Change order of templates 2021-01-04 13:52:30 +01:00
Tim Neutkens
de752b36a9
Update 1.bug_report.yml 2021-01-04 13:50:06 +01:00
Tim Neutkens
54cc9fcf47
Create 3.example_bug_report.yml 2021-01-04 13:49:37 +01:00
Tim Neutkens
62a1f1b747
Update 1.bug_report.yml 2021-01-04 13:02:06 +01:00
Tim Neutkens
cbb45205a3
Update 1.bug_report.yml 2021-01-04 13:00:57 +01:00
Tim Neutkens
ed78ee8187
Update 1.bug_report.yml 2021-01-04 13:00:29 +01:00
Tim Neutkens
89aab7dd90
Update 1.bug_report.yml 2021-01-04 12:58:25 +01:00
Tim Neutkens
d98481d561
Delete 2.Feature_request.md 2021-01-04 12:48:45 +01:00
Tim Neutkens
9c174c0db0
Update 2.feature_request.yml 2021-01-04 12:47:54 +01:00
Tim Neutkens
e8e35a8ca5
Create 2.feature_request.yml 2021-01-04 12:44:27 +01:00
Tim Neutkens
7c55651526
Update 1.bug_report.yml 2021-01-04 12:40:36 +01:00
Tim Neutkens
b7b4e4d455
Delete 1.Bug_report.md
This file has been replaced by the bug-report issue template
2021-01-04 12:39:13 +01:00
Tim Neutkens
8085e69ca9
Rename bug_report.yml to 1.bug_report.yml 2021-01-04 12:38:17 +01:00
Tim Neutkens
a61ba7b0d1
Update bug_report.yml 2021-01-04 11:39:49 +01:00
Tim Neutkens
ecafd218c7
Update bug_report.yml 2021-01-04 11:36:47 +01:00
Tim Neutkens
febb06558f
Update bug_report.yml 2021-01-04 11:36:35 +01:00
Tim Neutkens
5cb8aee415
Update bug_report.yml 2021-01-04 11:35:53 +01:00