archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rsnext/test/e2e/app-dir
History
Jiachi Liu de873d02b3
Prefer svg icon instead favicon if possible (#53343) 
### What?

Change the `favicon.ico` metadata `sizes` property from always `"any"`
to using the actual size possible

### Why?

When chrome/firefox browsers search for icon it needs the proper
metadata to determine which one to use, giving `favicon.ico` sizes with
`"any"` will prevent it loading the `icon.svg` as default icon when
available.

Changing to set proper size of `favicon.ico` (as the `favicon.ico` sizes
could be 16x16, 32x32, etc.) fixes the issue.

It works (loading svg icon) for chrome and firefox:

Firefox
<img width="505" alt="image"
src="https://github.com/vercel/next.js/assets/4800338/6873e595-479d-4d9e-ae5c-39e5f938fcf5">

Chrome
<img width="460" alt="image"
src="https://github.com/vercel/next.js/assets/4800338/03bbe4c7-ef76-4f34-a611-337b0d4b97a3">

It loads favicon.ico for Safari:
Using the `test/e2e/app-dir/metadata` app it shows the favicon.ico for
Safari
<img width="1000" alt="image"
src="https://github.com/vercel/next.js/assets/4800338/92cc8714-ea5e-432d-8144-2a4a42ee4ce2">

Can't have it as an e2e test as I tested it always loads the
`favicon.ico` in headless mode which can't determine the behaviors

Fixes #52002

Co-authored-by: JJ Kasper <jj@jjsweb.site>
2023-07-31 07:32:39 -07:00
..
_allow-underscored-root-directory Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
actions actions: fix revalidate after redirect (#53368) 2023-07-31 10:08:52 +00:00
app fix: Add Next-Url to http vary in consideration of intercept routes. (#52746) 2023-07-22 21:38:23 +00:00
app-a11y Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
app-alias Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
app-basepath Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
app-client-cache Renable flaky tests disabled before (#51680) 2023-07-03 09:29:28 +00:00
app-compilation Fix HMR for missing dependencies in next-app-loader (#51778) 2023-06-25 19:26:09 +00:00
app-css Ensure root layout only render once per request (#52589) 2023-07-13 17:34:31 +02:00
app-css-pageextensions Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
app-edge Fix bundle path normalization for /index routes (#52650) 2023-07-13 17:36:43 +02:00
app-edge-root-layout Fix static metadata routes runtime when root layout is in edge runtime (#50351) 2023-05-25 15:39:57 -07:00
app-external Avoid unnecessary resolveExternal calls (#52053) 2023-07-03 10:34:46 +02:00
app-middleware type check tests (and convert next-test-utils.js to ts) (#51071) 2023-06-23 17:42:50 +00:00
app-prefetch fix: Add Next-Url to http vary in consideration of intercept routes. (#52746) 2023-07-22 21:38:23 +00:00
app-prefetch-false type check tests (and convert next-test-utils.js to ts) (#51071) 2023-06-23 17:42:50 +00:00
app-rendering Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
app-routes Support basePath with edge runtime for Custom App Routes (#52910) 2023-07-19 23:54:34 +00:00
app-routes-trailing-slash Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
app-static add a "skip" cache type to verbose logging mode (#53275) 2023-07-28 20:01:31 +00:00
app-static-request-deduping Wrap incremental cache in an IPC server (#53030) 2023-07-26 23:19:46 +00:00
app-validation Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
asset-prefix Add new build and test workflow (#50436) 2023-05-27 21:02:31 -07:00
async-component-preload Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
autoscroll-with-css-modules Updates prettier to latest version. (#51000) 2023-06-09 14:58:19 +00:00
back-button-download-bug Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
build-size Split the client reference manifest file to be generated per-entry (#52450) 2023-07-10 09:48:03 +02:00
create-next-app-template Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
create-root-layout Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
crypto-globally-available Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
deopted-into-client-rendering-warning Ensure NEXT_DYNAMIC_NO_SSR_CODE has a unique name (#50219) 2023-05-23 08:37:57 -07:00
draft-mode Fix usage of router.refresh() with Draft Mode in App Router (#50941) 2023-06-09 00:15:55 +00:00
dynamic Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
dynamic-href Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
edge-runtime-node-compatibility Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
error-boundary-and-not-found-linking Fix not found hangs the build with overridden node env (#53106) 2023-07-24 21:00:53 +00:00
front-redirect-issue Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
global-error Catch layout error in global-error (#52654) 2023-07-14 00:43:40 +00:00
hello-world Bail out of 404 page when favicon.ico doesn't exist (#50795) 2023-06-06 10:58:40 +02:00
hooks Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
i18n-hybrid Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
import Support scroll: false for Link component for app router (#51869) 2023-07-04 10:25:25 +02:00
interception-middleware-rewrite Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
interoperability-with-pages improve error DX on pages with RSC build errors (#52843) 2023-07-20 00:32:57 +00:00
layout-params Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
mdx Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
metadata Prefer svg icon instead favicon if possible (#53343) 2023-07-31 07:32:39 -07:00
metadata-dynamic-routes Fix metadata layer webpack rule for server-only (#52403) 2023-07-09 18:23:51 +00:00
metadata-edge Fix tree shaking for image generation module (#51950) 2023-07-04 18:19:08 +00:00
metadata-missing-metadata-base fix: metadatabase warning message (#52363) 2023-07-07 00:08:10 +00:00
metadata-suspense Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
navigation Reland "Refine the not-found rendering process for app router" (#52985) 2023-07-21 10:09:30 -07:00
next-config Avoid loading Next.js config again in render workers (#52587) 2023-07-12 11:21:05 +00:00
next-font Simplify server CSS handling (#51018) 2023-06-14 14:43:08 -07:00
next-image fix: edge runtime with next/legacy/image (#50343) 2023-05-26 13:38:10 +02:00
not-found Fix file tracing issues for not-found pages (#53231) 2023-07-27 00:08:53 +00:00
pages-to-app-routing Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
parallel-routes-and-interception Fix client reference manifest for interception routes (#52961) 2023-07-20 20:06:44 +00:00
parallel-routes-not-found Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
rewrites-redirects Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
root-layout Ensure root layout only render once per request (#52589) 2023-07-13 17:34:31 +02:00
root-layout-not-found Reland "Refine the not-found rendering process for app router" (#52985) 2023-07-21 10:09:30 -07:00
root-layout-redirect Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
root-layout-render-once Ensure root layout only render once per request (#52589) 2023-07-13 17:34:31 +02:00
route-page-manifest-bug Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
router-autoscroll Support scroll: false for Link component for app router (#51869) 2023-07-04 10:25:25 +02:00
router-stuck-dynamic-static-segment Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
rsc-basic Fix tracking of ContextModule (#52795) 2023-07-17 17:41:04 +00:00
search-params-react-key Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
searchparams-static-bailout Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
set-cookies type check tests (and convert next-test-utils.js to ts) (#51071) 2023-06-23 17:42:50 +00:00
similar-pages-paths Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
test-template/{{ toFileName name }} Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
trailingslash Add new build and test workflow (#50436) 2023-05-27 21:02:31 -07:00
underscore-ignore-app-paths Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
use-params Update default moduleResolution in tsconfig.json from node to bundler (#51957) 2023-07-18 15:11:09 +00:00
use-selected-layout-segment-s Remove experimental config from create-next-app (#49241) 2023-05-05 00:22:28 -07:00
with-babel Apply optimization to middleware when using babel (#51067) 2023-06-09 13:33:14 -07:00
with-exported-function-config add version to function config manifest (#52507) 2023-07-10 20:28:59 +00:00